Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 809803002: Enabling Auth browser test for Chromoting on Windows. (Closed)

Created:
6 years ago by Łukasz Anforowicz
Modified:
6 years ago
Reviewers:
anandc, Jamie
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabling Auth browser test for Chromoting on Windows. I have tried running the Windows build of the Auth test locally and on a swarming bot and it consistently passes (both for v1 and v2 webapp). Therefore, as discussed with Anand I will enable Auth test for Windows, for v2 webapp. In the long-term we should extend coverage to v1 webapp, but this requires refactoring how parameters are passed to the tests (and is tracked by chromium issue here: https://code.google.com/p/chromium/issues/detail?id=423581). BUG=431488 Committed: https://crrev.com/5624cfb7e834ae9bd0196201e3e475aa09f90c45 Cr-Commit-Position: refs/heads/master@{#308685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M testing/chromoting/chromoting_integration_tests.isolate View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Łukasz Anforowicz
Anand - could you please take a look? Please note that this 1) should preserve ...
6 years ago (2014-12-16 18:11:10 UTC) #2
anandc
Assuming this change has been tested against a Windows and Mac Swarming bot and passes ...
6 years ago (2014-12-16 18:34:27 UTC) #4
Łukasz Anforowicz
On 2014/12/16 18:34:27, anandc wrote: > Assuming this change has been tested against a Windows ...
6 years ago (2014-12-16 20:48:06 UTC) #5
Jamie
lgtm
6 years ago (2014-12-16 20:53:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809803002/1
6 years ago (2014-12-16 20:56:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 22:42:14 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-16 22:42:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5624cfb7e834ae9bd0196201e3e475aa09f90c45
Cr-Commit-Position: refs/heads/master@{#308685}

Powered by Google App Engine
This is Rietveld 408576698