Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: pkg/analyzer/test/generated/engine_test.dart

Issue 809793002: Improve nomenclature of new AnalysisContext async method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/engine_test.dart
diff --git a/pkg/analyzer/test/generated/engine_test.dart b/pkg/analyzer/test/generated/engine_test.dart
index d2105e4b7464fe3f9eba6133b77632df5fcd0454..2424e2dea2ac21fc327e6b63d9a81f8fde66c80e 100644
--- a/pkg/analyzer/test/generated/engine_test.dart
+++ b/pkg/analyzer/test/generated/engine_test.dart
@@ -1139,7 +1139,7 @@ main() {}''');
DartEntry dartEntry = _context.getReadableSourceEntryOrNull(source);
dartEntry.flushAstStructures();
bool completed = false;
- _context.getResolvedCompilationUnitFuture(
+ _context.computeResolvedCompilationUnitAsync(
source,
source).then((CompilationUnit unit) {
expect(unit, isNotNull);
@@ -1163,7 +1163,7 @@ main() {}''');
DartEntry dartEntry = _context.getReadableSourceEntryOrNull(source);
dartEntry.flushAstStructures();
CancelableFuture<CompilationUnit> future =
- _context.getResolvedCompilationUnitFuture(source, source);
+ _context.computeResolvedCompilationUnitAsync(source, source);
bool completed = false;
future.then((CompilationUnit unit) {
fail('Future should have been canceled');
@@ -1187,7 +1187,7 @@ main() {}''');
Source librarySource = _addSource("/lib.dart", "library lib;");
Source partSource = _addSource("/part.dart", "part of foo;");
bool completed = false;
- _context.getResolvedCompilationUnitFuture(
+ _context.computeResolvedCompilationUnitAsync(
partSource,
librarySource).then((_) {
fail('Expected resolution to fail');
@@ -6016,6 +6016,12 @@ class TestAnalysisContext implements InternalAnalysisContext {
return null;
}
@override
+ Future<CompilationUnit> computeResolvedCompilationUnitAsync(Source source,
+ Source librarySource) {
+ fail("Unexpected invocation of getResolvedCompilationUnitFuture");
+ return null;
+ }
+ @override
void dispose() {
fail("Unexpected invocation of dispose");
}
@@ -6118,12 +6124,6 @@ class TestAnalysisContext implements InternalAnalysisContext {
return null;
}
@override
- Future<CompilationUnit> getResolvedCompilationUnitFuture(Source source,
- Source librarySource) {
- fail("Unexpected invocation of getResolvedCompilationUnitFuture");
- return null;
- }
- @override
ht.HtmlUnit getResolvedHtmlUnit(Source htmlSource) {
fail("Unexpected invocation of getResolvedHtmlUnit");
return null;
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698