build/config/win/visual_studio_version.gni - Issue 809783002: Fix ui/gl and gpu target building with GN on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/visual_studio_version.gni

Issue 809783002: Fix ui/gl and gpu target building with GN on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better way to overcome include search order problem. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/win/visual_studio_version.gni

diff --git a/build/config/win/visual_studio_version.gni b/build/config/win/visual_studio_version.gni

index 24c00cd6d98a68e9e5a7faf3f8cd16b39c96fecb..a8f5ade343676d8e8331fdd3cd1b00c8ffc9cac4 100644

--- a/build/config/win/visual_studio_version.gni

+++ b/build/config/win/visual_studio_version.gni

@@ -42,14 +42,5 @@ if (visual_studio_path == "") {

"You must set the wdk_path if you set the visual studio path")

visual_studio_runtime_dirs = []

}

-# The Windows SDK include directories must be first. They both have a sal.h,

-# and the SDK one is newer and the SDK uses some newer features from it not

-# present in the Visual Studio one.

-system_include_dirs = [

- "$windows_sdk_path\Include\shared",

- "$windows_sdk_path\Include\um",

- "$windows_sdk_path\Include\winrt",

- "$visual_studio_path\VC\include",

- "$visual_studio_path\VC\atlmfc\include",

+# System include dirs must be set by setup_toolchain.py script. Since in

brettw 2014/12/17 19:21:35 Seems like this comment can be deleted. It doesn't

+# other case we'll get not proper include search order.

« no previous file with comments | « BUILD.gn ('k') | build/toolchain/win/setup_toolchain.py » ('j') | no next file with comments »