Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 809753002: Revert of telemetry: Clean up SurfaceFlinger statistics (Closed)

Created:
6 years ago by bokan
Modified:
6 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, telemetry+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, aelias_OOO_until_Jul13, klobag.chromium, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of telemetry: Clean up SurfaceFlinger statistics (patchset #8 id:140001 of https://codereview.chromium.org/765773004/) Reason for revert: Perf sheriff here, speculatively reverting due to crbug.com/442752, it shows up in many blamelists (but not all as the test wasn't running due to another bug). Sorry if unrelated. Original issue's description: > PERF-SHERIFFS: This patch will change all smoothness and SurfaceFlinger metrics on Android. Some metrics may go up or down significantly, with the new values being more accurate. > > This patch cleans up the integration of SurfaceFlinger statistics by pulling the > raw timestamps into the timeline and calculating all metrics in > SmoothnessMetric. This approach also improves the metrics, because the > timeline ranges can now be properly bounded (no more percentiles!) and the > existing smoothness metrics can also use the more accurate SurfaceFlinger > timestamps. > > BUG=351916 > > Committed: https://crrev.com/ebae600f54ed1e77eeba916635310fb176c0fb6c > Cr-Commit-Position: refs/heads/master@{#308488} TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,chrishenry@google.com,skyostil@google.com,sullivan@chromium.org,skyostil@chromium.org,jbudorick@chromium.org,ernstm@chromium.org NOTREECHECKS=true NOTRY=true BUG=351916 Committed: https://crrev.com/3dfc4e90757197efe0855fd4889d32bc52cb4cf9 Cr-Commit-Position: refs/heads/master@{#308594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -347 lines) Patch
M build/android/pylib/perf/surface_stats_collector.py View 7 chunks +138 lines, -17 lines 0 comments Download
A build/android/surface_stats.py View 1 chunk +142 lines, -0 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 4 chunks +31 lines, -13 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/__init__.py View 1 chunk +33 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 3 chunks +16 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/ios_platform_backend.py View 2 chunks +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/platform_backend.py View 1 chunk +10 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model.py View 4 chunks +1 line, -14 lines 0 comments Download
D tools/telemetry/telemetry/timeline/surface_flinger_importer.py View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/telemetry/telemetry/timeline/surface_flinger_timeline_data.py View 1 chunk +0 lines, -29 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py View 3 chunks +2 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py View 6 chunks +4 lines, -77 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 3 chunks +4 lines, -73 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 3 chunks +2 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bokan
Created Revert of telemetry: Clean up SurfaceFlinger statistics
6 years ago (2014-12-16 16:08:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809753002/1
6 years ago (2014-12-16 16:09:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 16:10:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3dfc4e90757197efe0855fd4889d32bc52cb4cf9 Cr-Commit-Position: refs/heads/master@{#308594}
6 years ago (2014-12-16 16:11:14 UTC) #4
bokan
6 years ago (2014-12-16 17:49:21 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/804413002/ by bokan@chromium.org.

The reason for reverting is: Relanding, this patch was not the culprit. Sorry..

Powered by Google App Engine
This is Rietveld 408576698