Add an Observer interface to UsbService for device add/remove.

chrome/browser/extensions/api/device_permissions_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/values_test_util.h"
 #include "chrome/browser/extensions/test_extension_environment.h"
 #include "chrome/test/base/testing_profile.h"
+#include "device/core/device_client.h"
 #include "device/usb/usb_device.h"
 #include "device/usb/usb_device_handle.h"
 #include "extensions/browser/api/device_permissions_manager.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/common/extension.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace extensions {
 
 namespace {
 
 using device::UsbDevice;
 using device::UsbDeviceHandle;
+using device::UsbService;
 using testing::Return;
 
+class MockUsbService : public UsbService {
+ public:
+  MockUsbService() : mock_device_client(this) {}
+
+  MOCK_METHOD1(GetDeviceById, scoped_refptr<UsbDevice>(uint32));
+  MOCK_METHOD1(GetDevices, void(std::vector<scoped_refptr<UsbDevice>>*));
+
+  // Public wrapper for the protected NotifyDeviceRemove function.
+  void NotifyDeviceRemoved(scoped_refptr<UsbDevice> device) {
+    UsbService::NotifyDeviceRemoved(device);
+  }
+
+ private:
+  class MockDeviceClient : device::DeviceClient {
+   public:
+    explicit MockDeviceClient(UsbService* usb_service)
+        : usb_service_(usb_service) {}
+
+    UsbService* GetUsbService() override { return usb_service_; }
+
+   private:
+    UsbService* usb_service_;
+  };
+
+  MockDeviceClient mock_device_client;
+};
+
 class MockUsbDevice : public UsbDevice {
  public:
   MockUsbDevice(const std::string& serial_number, uint32 unique_id)
       : UsbDevice(0, 0, unique_id), serial_number_(serial_number) {}
 
   MOCK_METHOD0(Open, scoped_refptr<UsbDeviceHandle>());
   MOCK_METHOD1(Close, bool(scoped_refptr<UsbDeviceHandle>));
 #if defined(OS_CHROMEOS)
   MOCK_METHOD2(RequestUsbAccess, void(int, const base::Callback<void(bool)>&));
 #endif
@@ skipping 13 matching lines @@
     if (serial_number_.empty()) {
       // Return false as if the device does not have or failed to return its
       // serial number.
       return false;
     }
 
     *serial_number = base::UTF8ToUTF16(serial_number_);
     return true;
   }
 
-  void NotifyDisconnect() { UsbDevice::NotifyDisconnect(); }
-
  private:
   virtual ~MockUsbDevice() {}
 
   const std::string serial_number_;
 };
 
 void AllowUsbDevice(DevicePermissionsManager* manager,
                     const Extension* extension,
                     scoped_refptr<UsbDevice> device) {
   // If the device cannot provide any of these strings they will simply by
   // empty.
   base::string16 product;
   device->GetProduct(&product);
   base::string16 manufacturer;
   device->GetManufacturer(&manufacturer);
   base::string16 serial_number;
   device->GetSerialNumber(&serial_number);
 
   manager->AllowUsbDevice(
       extension->id(), device, product, manufacturer, serial_number);
 }
 
 }  // namespace
 
 class DevicePermissionsManagerTest : public testing::Test {
  protected:
   void SetUp() override {
     testing::Test::SetUp();
-    env_.GetExtensionPrefs();  // Force creation before adding extensions.
-    extension_ = env_.MakeExtension(*base::test::ParseJson(
-                                        "{"
-                                        "  \"app\": {"
-                                        "    \"background\": {"
-                                        "      \"scripts\": [\"background.js\"]"
-                                        "    }"
-                                        "  },"
-                                        "  \"permissions\": ["
-                                        "    \"usb\""
-                                        "  ]"
-                                        "}"));
+    env_.reset(new TestExtensionEnvironment());
+    env_->GetExtensionPrefs();  // Force creation before adding extensions.
+    extension_ =
+        env_->MakeExtension(*base::test::ParseJson(
+                                "{"
+                                "  \"app\": {"
+                                "    \"background\": {"
+                                "      \"scripts\": [\"background.js\"]"
+                                "    }"
+                                "  },"
+                                "  \"permissions\": ["
+                                "    \"usb\""
+                                "  ]"
+                                "}"));
     device0 = new MockUsbDevice("ABCDE", 0);
     device1 = new MockUsbDevice("", 1);
     device2 = new MockUsbDevice("12345", 2);
     device3 = new MockUsbDevice("", 3);
+    usb_service_ = new MockUsbService();
+    UsbService::SetInstanceForTest(usb_service_);
   }
 
-  extensions::TestExtensionEnvironment env_;
+  void TearDown() override {
+    env_.reset(nullptr);
+    UsbService::SetInstanceForTest(nullptr);
+  }
+
+  scoped_ptr<extensions::TestExtensionEnvironment> env_;
   const extensions::Extension* extension_;
+  MockUsbService* usb_service_;
   scoped_refptr<MockUsbDevice> device0;
   scoped_refptr<MockUsbDevice> device1;
   scoped_refptr<MockUsbDevice> device2;
   scoped_refptr<MockUsbDevice> device3;
 };
 
 TEST_F(DevicePermissionsManagerTest, AllowAndClearDevices) {
   DevicePermissionsManager* manager =
-      DevicePermissionsManager::Get(env_.profile());
+      DevicePermissionsManager::Get(env_->profile());
   AllowUsbDevice(manager, extension_, device0);
   AllowUsbDevice(manager, extension_, device1);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   scoped_refptr<DevicePermissionEntry> device0_entry =
       device_permissions->FindEntry(device0);
   ASSERT_TRUE(device0_entry.get());
   scoped_refptr<DevicePermissionEntry> device1_entry =
       device_permissions->FindEntry(device1);
@@ skipping 23 matching lines @@
 
   device_permissions = manager->GetForExtension(extension_->id());
   ASSERT_TRUE(device_permissions->FindEntry(device0).get());
   ASSERT_TRUE(device_permissions->FindEntry(device1).get());
   ASSERT_FALSE(device_permissions->FindEntry(device2).get());
   ASSERT_FALSE(device_permissions->FindEntry(device3).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, SuspendExtension) {
   DevicePermissionsManager* manager =
-      DevicePermissionsManager::Get(env_.profile());
+      DevicePermissionsManager::Get(env_->profile());
   AllowUsbDevice(manager, extension_, device0);
   AllowUsbDevice(manager, extension_, device1);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   ASSERT_TRUE(device_permissions->FindEntry(device0).get());
   ASSERT_TRUE(device_permissions->FindEntry(device1).get());
   ASSERT_FALSE(device_permissions->FindEntry(device2).get());
   ASSERT_FALSE(device_permissions->FindEntry(device3).get());
 
   manager->OnBackgroundHostClose(extension_->id());
 
   device_permissions = manager->GetForExtension(extension_->id());
   // Device 0 is still registered because its serial number has been stored in
   // ExtensionPrefs, it is "persistent".
   ASSERT_TRUE(device_permissions->FindEntry(device0).get());
   // Device 1 does not have uniquely identifying traits and so permission to
   // open it has been dropped when the app's windows have closed and the
   // background page has been suspended.
   ASSERT_FALSE(device_permissions->FindEntry(device1).get());
   ASSERT_FALSE(device_permissions->FindEntry(device2).get());
   ASSERT_FALSE(device_permissions->FindEntry(device3).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, DisconnectDevice) {
   DevicePermissionsManager* manager =
-      DevicePermissionsManager::Get(env_.profile());
+      DevicePermissionsManager::Get(env_->profile());
   AllowUsbDevice(manager, extension_, device0);
   AllowUsbDevice(manager, extension_, device1);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   ASSERT_TRUE(device_permissions->FindEntry(device0).get());
   ASSERT_TRUE(device_permissions->FindEntry(device1).get());
   ASSERT_FALSE(device_permissions->FindEntry(device2).get());
   ASSERT_FALSE(device_permissions->FindEntry(device3).get());
 
-  device0->NotifyDisconnect();
-  device1->NotifyDisconnect();
+  usb_service_->NotifyDeviceRemoved(device0);
+  usb_service_->NotifyDeviceRemoved(device1);
 
   device_permissions = manager->GetForExtension(extension_->id());
   // Device 0 will be accessible when it is reconnected because it can be
   // recognized by its serial number.
   ASSERT_TRUE(device_permissions->FindEntry(device0).get());
   // Device 1 does not have a serial number and cannot be distinguished from
   // any other device of the same model so the app must request permission again
   // when it is reconnected.
   ASSERT_FALSE(device_permissions->FindEntry(device1).get());
   ASSERT_FALSE(device_permissions->FindEntry(device2).get());
   ASSERT_FALSE(device_permissions->FindEntry(device3).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, RevokeAndRegrantAccess) {
   DevicePermissionsManager* manager =
-      DevicePermissionsManager::Get(env_.profile());
+      DevicePermissionsManager::Get(env_->profile());
   AllowUsbDevice(manager, extension_, device0);
   AllowUsbDevice(manager, extension_, device1);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   scoped_refptr<DevicePermissionEntry> device0_entry =
       device_permissions->FindEntry(device0);
   ASSERT_TRUE(device0_entry.get());
   scoped_refptr<DevicePermissionEntry> device1_entry =
       device_permissions->FindEntry(device1);
@@ skipping 15 matching lines @@
   ASSERT_FALSE(device_permissions->FindEntry(device1).get());
 
   AllowUsbDevice(manager, extension_, device1);
   device_permissions = manager->GetForExtension(extension_->id());
   ASSERT_TRUE(device_permissions->FindEntry(device0).get());
   ASSERT_TRUE(device_permissions->FindEntry(device1).get());
 }
 
 TEST_F(DevicePermissionsManagerTest, UpdateLastUsed) {
   DevicePermissionsManager* manager =
-      DevicePermissionsManager::Get(env_.profile());
+      DevicePermissionsManager::Get(env_->profile());
   AllowUsbDevice(manager, extension_, device0);
 
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   scoped_refptr<DevicePermissionEntry> device0_entry =
       device_permissions->FindEntry(device0);
   ASSERT_TRUE(device0_entry->last_used().is_null());
 
   manager->UpdateLastUsed(extension_->id(), device0_entry);
   device_permissions = manager->GetForExtension(extension_->id());
   device0_entry = device_permissions->FindEntry(device0);
   ASSERT_FALSE(device0_entry->last_used().is_null());
 }
 
 TEST_F(DevicePermissionsManagerTest, LoadPrefs) {
   scoped_ptr<base::Value> prefs_value = base::test::ParseJson(
       "["
       "  {"
       "    \"product_id\": 0,"
       "    \"serial_number\": \"ABCDE\","
       "    \"type\": \"usb\","
       "    \"vendor_id\": 0"
       "  }"
       "]");
-  env_.GetExtensionPrefs()->UpdateExtensionPref(
-      extension_->id(), "devices", prefs_value.release());
+  env_->GetExtensionPrefs()->UpdateExtensionPref(extension_->id(), "devices",
+                                                 prefs_value.release());
 
   DevicePermissionsManager* manager =
-      DevicePermissionsManager::Get(env_.profile());
+      DevicePermissionsManager::Get(env_->profile());
   scoped_ptr<DevicePermissions> device_permissions =
       manager->GetForExtension(extension_->id());
   ASSERT_TRUE(device_permissions->FindEntry(device0).get());
   ASSERT_FALSE(device_permissions->FindEntry(device1).get());
   ASSERT_FALSE(device_permissions->FindEntry(device2).get());
   ASSERT_FALSE(device_permissions->FindEntry(device3).get());
 }
 
 }  // namespace extensions