Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 809743005: Add TLS_DHE_RSA_WITH_CHACHA20_POLY1305 to ssl_cipher_suite_names.cc (Closed)

Created:
5 years, 11 months ago by davidben
Modified:
5 years, 11 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TLS_DHE_RSA_WITH_CHACHA20_POLY1305 to ssl_cipher_suite_names.cc The OpenSSL and BoringSSL ports support one additional CHACHA20_POLY1305 variant. Add it to the list so it gets categorized correctly. (diff is large because presubmit wanted a git cl format.) BUG=none Committed: https://crrev.com/945fc2d045fe2b3ac024866414ad8ae49dcd9640 Cr-Commit-Position: refs/heads/master@{#311325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -166 lines) Patch
M net/ssl/ssl_cipher_suite_names.cc View 1 chunk +167 lines, -166 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Added it to unit tests so make sure I didn't get the addition wrong.
5 years, 11 months ago (2015-01-05 21:04:18 UTC) #2
agl
lgtm
5 years, 11 months ago (2015-01-13 20:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809743005/1
5 years, 11 months ago (2015-01-13 20:48:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 21:19:13 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:21:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/945fc2d045fe2b3ac024866414ad8ae49dcd9640
Cr-Commit-Position: refs/heads/master@{#311325}

Powered by Google App Engine
This is Rietveld 408576698