SyncFS: Clean up callbacks in v1 tests

SyncFS: Clean up callbacks in v1 tests

BUG=n/a
TEST=should pass all existing tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238414

[nhiroki, 2013-11-22 01:53:04]

ptal

[tzik, 2013-11-22 04:48:15]

https://codereview.chromium.org/80973002/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/sync_file_system_test_util.h (right):

https://codereview.chromium.org/80973002/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/sync_file_system_test_util.h:31: void
ReceiveResultConst2(bool* done,
This looks not clean to me...
And to make this cleaner, we need to do some template magic like
boost::call_traits::param_type.

For now, can we leave them as is?

[kinuko, 2013-11-22 04:52:40]

https://codereview.chromium.org/80973002/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/sync_file_system_test_util.h (right):

https://codereview.chromium.org/80973002/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/sync_file_system_test_util.h:57: }
Is it reasonable to specify we always use const & for some types?  Like:



template <typename T> struct ParamTraits {
  typedef T Type;
};
template <typename T> struct ParamTraits<std::vector<T> > {
  typedef const std::vector<T>& Type;
};
template <> struct ParamTraits<fileapi::FileSystemURL> {
  typedef const fileapi::FileSystemURL& Type;
};

template <typename Arg1, typename Arg2, typename A1, typename A2>
void ReceiveResult2(bool* done,
                    Arg1* arg1_out,
                    Arg2* arg2_out,
                    A1 arg1,
                    A2 arg2) {
  EXPECT_FALSE(*done);
  *done = true;
  *arg1_out = base::internal::CallbackForward(arg1);
  *arg2_out = base::internal::CallbackForward(arg2);
}

template <typename Arg1, typename Arg2, 
          typename A1 = typename ParamTraits<Arg1>::Type,
          typename A2 = typename ParamTraits<Arg2>::Type>
base::Callback<void(A1, A2)>
CreateResultReceiver(Arg1* arg1_out, Arg2* arg2_out) {
  return base::Bind(&ReceiveResult2<Arg1, Arg2, A1, A2>,
                    base::Owned(new bool(false)),
                    arg1_out, arg2_out);
}

[tzik, 2013-12-03 12:20:07]

lgtm

[kinuko, 2013-12-03 13:28:28]

lgtm2

[commit-bot: I haz the power, 2013-12-03 13:37:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/80973002/220001

[commit-bot: I haz the power, 2013-12-03 17:07:38]

Change committed as 238414