Change the protocol for component updates from http to https.

Change the protocol for component updates from http to https.

BUG=124228
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236960

[Sorin Jianu, 2013-11-21 21:09:18]

This is changing the scheme of the update check url from http to https. The
pings remain over http.

The unit tests still use http, mostly because the interceptor class we are using
is intercepting "http". Since this is just a lexical difference for the unit
tests, I think it is acceptable to leave them on http.

[waffles, 2013-11-21 21:36:31]

lgtm

[cpu_(ooo_6.6-7.5), 2013-11-22 21:40:22]

lgtm

[commit-bot: I haz the power, 2013-11-22 21:42:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/80963004/1

[commit-bot: I haz the power, 2013-11-22 21:42:18]

Failed to apply patch for
chrome/browser/component_updater/component_updater_configurator.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/component_updater/component_updater_configurator.cc
  Hunk #1 FAILED at 43.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/component_updater/component_updater_configurator.cc.rej

Patch:       chrome/browser/component_updater/component_updater_configurator.cc
Index: chrome/browser/component_updater/component_updater_configurator.cc
diff --git a/chrome/browser/component_updater/component_updater_configurator.cc
b/chrome/browser/component_updater/component_updater_configurator.cc
index
8f870a854c20736a4b6c6a85b4a765b149a7deb4..d2faa1ffde79618de636d91e1fdfb3c752969fa4
100644
--- a/chrome/browser/component_updater/component_updater_configurator.cc
+++ b/chrome/browser/component_updater/component_updater_configurator.cc
@@ -43,7 +43,7 @@ const char kSwitchUrlSource[] = "url-source";
 // The default url from which an update manifest can be fetched. Can be
 // overridden with --component-updater=url-source=someurl.
 const char kDefaultUrlSource[] =
-    "http://clients2.google.com/service/update2/crx";
+    "https://clients2.google.com/service/update2/crx";
 
 // The url to send the pings to.
 const char kPingUrl[] = "http://tools.google.com/service/update2";

[Sorin Jianu, 2013-11-22 22:58:23]

Josh, please take another look, I had to rebase the CL since you've last
reviewed it.

[waffles, 2013-11-22 22:59:59]

https://codereview.chromium.org/80963004/diff/120001/chrome/browser/component...
File chrome/browser/component_updater/component_updater_configurator.cc (right):

https://codereview.chromium.org/80963004/diff/120001/chrome/browser/component...
chrome/browser/component_updater/component_updater_configurator.cc:46:
"https://clients2.google.com/service/update2/crx";
I think we don't want the /crx, right?

[Sorin Jianu, 2013-11-22 23:18:54]

Thank you Josh, PTAL.

https://codereview.chromium.org/80963004/diff/120001/chrome/browser/component...
File chrome/browser/component_updater/component_updater_configurator.cc (right):

https://codereview.chromium.org/80963004/diff/120001/chrome/browser/component...
chrome/browser/component_updater/component_updater_configurator.cc:46:
"https://clients2.google.com/service/update2/crx";
On 2013/11/22 23:00:00, waffles wrote:
> I think we don't want the /crx, right?

Thank you!

[waffles, 2013-11-22 23:21:33]

lgtm

[commit-bot: I haz the power, 2013-11-22 23:27:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/80963004/170001

[commit-bot: I haz the power, 2013-11-23 20:27:50]

Change committed as 236960