Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809613008: Expose MediaQueryList interface and make arguments non-optional (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-css, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, kenneth.christiansen, rwlbuis, Yoav Weiss
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose MediaQueryList interface and make arguments non-optional http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface In Firefox Nightly and IE11, the interface is already exposed and calling addListener() or removeListener() throws an exception, making this change likely Web compatible. The added early returns in the implementation are per spec, but redudant with similar checks decorated with FIXMEs in EventTarget. Save some trouble for the time when those are removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187449

Patch Set 1 #

Total comments: 1

Patch Set 2 : minimize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
A LayoutTests/fast/media/media-query-list-missing-arguments.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/media/media-query-list-missing-arguments-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryList.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryList.idl View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
6 years ago (2014-12-17 14:47:25 UTC) #2
rune
lgtm with nit https://codereview.chromium.org/809613008/diff/1/LayoutTests/fast/media/media-query-list-missing-arguments.html File LayoutTests/fast/media/media-query-list-missing-arguments.html (right): https://codereview.chromium.org/809613008/diff/1/LayoutTests/fast/media/media-query-list-missing-arguments.html#newcode2 LayoutTests/fast/media/media-query-list-missing-arguments.html:2: <html> Skip html, head, body.
6 years ago (2014-12-18 09:43:11 UTC) #3
philipj_slow
minimize
6 years ago (2014-12-18 10:29:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809613008/20001
6 years ago (2014-12-18 10:30:13 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-18 11:44:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187449

Powered by Google App Engine
This is Rietveld 408576698