Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809603003: Plumb preamble log data from the hotword extension into the speech recognizer. (Closed)

Created:
6 years ago by Anand Mistry (off Chromium)
Modified:
6 years ago
Reviewers:
rpetterson, calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, tfarina, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb preamble log data from the hotword extension into the speech recognizer. BUG=397019 Committed: https://crrev.com/7608f02ae8f93fb125b6fd4c4c6ff9ab46989349 Cr-Commit-Position: refs/heads/master@{#309332}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -25 lines) Patch
M chrome/browser/extensions/api/hotword_private/hotword_private_api.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/search/hotword_client.h View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service.h View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 4 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/speech_recognizer.h View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/speech_recognizer.cc View 6 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/speech_recognizer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Anand Mistry (off Chromium)
rlp@chromium.org: Please review changes in *hotword* calamity@chromium.org: Please review changes in app_list Sending this out ...
6 years ago (2014-12-16 04:52:16 UTC) #2
calamity
lgtm
6 years ago (2014-12-16 06:45:50 UTC) #3
rpetterson
hotword LGTM
6 years ago (2014-12-16 06:58:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809603003/40001
6 years ago (2014-12-20 02:59:35 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-20 03:47:15 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-20 03:48:05 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7608f02ae8f93fb125b6fd4c4c6ff9ab46989349
Cr-Commit-Position: refs/heads/master@{#309332}

Powered by Google App Engine
This is Rietveld 408576698