Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 809553006: VTTCue: Get rid of undefinedSize (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

VTTCue: Get rid of undefinedSize Let the initial value be NaN instead. (It's only used as a sentinel for an assertion, so any invalid/out-of-range value will do.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/core/html/track/vtt/VTTCue.cpp View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Oprah hands out NaNs to everybody!
5 years, 11 months ago (2015-01-21 12:50:40 UTC) #2
philipj_slow
lgtm
5 years, 11 months ago (2015-01-21 15:04:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809553006/1
5 years, 11 months ago (2015-01-21 15:04:25 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 15:59:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188749

Powered by Google App Engine
This is Rietveld 408576698