Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 809553005: Using "static_assert" in lieu of "COMPILE_ASSERT" in storage module (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using "static_assert" in lieu of "COMPILE_ASSERT" in storage module All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now. BUG=442514 Committed: https://crrev.com/4bd5ab2bd10ae5c2a52fb5c4b26ffa6da417377d Cr-Commit-Position: refs/heads/master@{#312553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M storage/browser/fileapi/task_runner_bound_observer_list.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-21 12:59:25 UTC) #2
piman
lgtm
5 years, 11 months ago (2015-01-21 18:04:27 UTC) #3
anujsharma
On 2015/01/21 18:04:27, piman (Very slow to review) wrote: > lgtm Thanks piman for lgtm.
5 years, 11 months ago (2015-01-22 00:46:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809553005/1
5 years, 11 months ago (2015-01-22 00:47:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 03:26:11 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 03:27:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bd5ab2bd10ae5c2a52fb5c4b26ffa6da417377d
Cr-Commit-Position: refs/heads/master@{#312553}

Powered by Google App Engine
This is Rietveld 408576698