Send NPAPI focus messages when web contents is blurred or focused

Send NPAPI focus messages when web contents is blurred or focused

Adobe Flash requires NPP focus event to switch system input events listening.
If this event is not sent, Flash plugin malfunctions and acts as a global system
keylogger (bypassing the browser).

BUG=442670
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189331

[mmal, 2014-12-16 10:49:10]

mmaliszkiewicz@opera.com changed reviewers:
+ eae@chromium.org, esprehn@chromium.org, rune@opera.com

[rune, 2014-12-16 11:07:06]

Tests are missing.

The CL description needs to say what and why.

DNA-31362 is an Opera bug id should be removed from the description.

I don't have access to issue 442670.

I doubt any of the listed reviewers are the right for this CL.

I believe NPAPI is going away any time soon, so I'm not sure patches will be
accepted. I'm not in the loop here, so I don't know the policy.

[mmal, 2014-12-16 16:21:11]

On 2014/12/16 11:07:06, rune wrote:
> Tests are missing.
Yes, because I don't know how to tie checking IPC messages with manipulating
focus.

> The CL description needs to say what and why.
Little info here on purpose, more details under linked bug.

> I don't have access to issue 442670.
You can view DNA in our BTS, it's mostly the same.

> I doubt any of the listed reviewers are the right for this CL.
git cl owners and viewing git logs led me to adding them. I hope someone who
knows people's area of expertise will help adding appropriate people.

[rune, 2014-12-16 23:43:04]

On 2014/12/16 at 16:21:11, mmaliszkiewicz wrote:
> On 2014/12/16 11:07:06, rune wrote:
> > Tests are missing.
> Yes, because I don't know how to tie checking IPC messages with manipulating
focus.

I haven't used this myself, but there seems to be a test NPAPI plugin located
here in src/content/shell/tools/plugin/ where tests in LayoutTests/plugins use
output from that plugin as expected results.

> > The CL description needs to say what and why.
> Little info here on purpose, more details under linked bug.

In Blink, the essential information should go into the CL description, not
depend on the bug tracker. See
http://www.chromium.org/developers/contributing-code#TOC-Change-List-Descript...

> > I doubt any of the listed reviewers are the right for this CL.
> git cl owners and viewing git logs led me to adding them. I hope someone who
knows people's area of expertise will help adding appropriate people.

Doing git log and blame, I'd say tkent@ might be a good bet.

[mmal, 2014-12-17 15:08:54]

> Doing git log and blame, I'd say tkent@ might be a good bet.
He is on vacation until February.

[esprehn, 2014-12-17 18:35:21]

Can you explain better in the change description? I can't see that bug, is it a
security bug?

[mmal, 2014-12-18 10:13:58]

On 2014/12/17 18:35:21, esprehn wrote:
> Can you explain better in the change description? I can't see that bug, is it
a
> security bug?

Yes it is. Owner is bbudge@chromium.org, maybe he can CC you? Basically it's
about that other browsers are sending focus messages when changing tab/window
and chrome doesn't which causes flash malfunction.

[esprehn, 2015-01-27 07:26:55]

lgtm, can you expand the change description to say that this prevents plugins
from getting input events when they're not really focused anymore? We don't need
to make commits cryptic on security bugs. :)

thanks for fixing this btw, this is an ancient bug. I remember the first time I
saw a game do it and thinking "wtf?"

[esprehn, 2015-01-27 07:27:46]

btw having a test would be nice, but you don't need to block landing this fix on
the test.

[mmal, 2015-01-29 12:51:00]

On 2015/01/27 07:27:46, esprehn wrote:
> btw having a test would be nice, but you don't need to block landing this fix
on
> the test.

Message updated, my initial cryptic info was due to not checking "Protected"
checkbox because I wanted to include Rune and he has @opera.com account.
Tangled...

I'll try to make a test  in the following days. I need somehow tie received NPP
events checking and switching tabs/windows.

[mmal, 2015-01-29 12:51:48]

The CQ bit was checked by mmaliszkiewicz@opera.com

[commit-bot: I haz the power, 2015-01-29 12:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809523003/1

[rune, 2015-01-29 12:57:46]

"If this event is not send Flash ..." -> "If this event is not sent, Flash ..."

"keyloger" -> "keylogger"

[commit-bot: I haz the power, 2015-01-29 13:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 13:03:24]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[mmal, 2015-01-30 13:42:37]

Patchset #2 (id:20001) has been deleted

[mmal, 2015-02-02 10:40:54]

The CQ bit was checked by mmaliszkiewicz@opera.com

[commit-bot: I haz the power, 2015-02-02 10:41:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809523003/60001

[commit-bot: I haz the power, 2015-02-02 11:53:56]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189331