Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809513002: XFA: merge patch from issue 801913002 and 804463003 (Closed)

Created:
6 years ago by jam
Modified:
6 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: merge patch from issue 801913002 and 804463003 Simplify PDFium by removing code that's not used in the open source repo. -remove parameter from FPDF_InitLibrary -remove a bunch of ifdefs that are unused Fix build after previous commit. TBR=tsepez@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/207299b5d46e3e0612dd6a0264fb7647177312bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1864 lines) Patch
M BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M core/include/fpdfapi/fpdf_module.h View 2 chunks +0 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_basic_module.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 2 chunks +0 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 7 chunks +1 line, -38 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_utility.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 9 chunks +0 lines, -94 lines 0 comments Download
D core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp View 1 chunk +0 lines, -822 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 5 chunks +0 lines, -40 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 23 chunks +0 lines, -59 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 4 chunks +1 line, -35 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 13 chunks +0 lines, -83 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +0 lines, -4 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 4 chunks +0 lines, -17 lines 0 comments Download
M core/src/fxcodec/libjpeg/fpdfapi_jerror.c View 2 chunks +0 lines, -13 lines 0 comments Download
M core/src/fxcodec/libjpeg/jmemsys.h View 3 chunks +1 line, -38 lines 0 comments Download
M core/src/fxge/agg/agg23/fx_agg_driver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 3 chunks +0 lines, -11 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 7 chunks +0 lines, -10 lines 0 comments Download
M core/src/fxge/fx_freetype/fxft2.5.01/src/psnames/fxft_psmodule.c View 2 chunks +0 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 6 chunks +1 line, -29 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 chunk +1 line, -26 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 6 chunks +3 lines, -11 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
D fpdfsdk/include/fpdfoom.h View 1 chunk +0 lines, -61 lines 0 comments Download
M fpdfsdk/include/fpdfview.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +27 lines, -60 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 2 chunks +1 line, -6 lines 0 comments Download
D fpdfsdk/src/fpdfoom.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 4 chunks +1 line, -72 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M pdfium.gyp View 4 chunks +0 lines, -4 lines 0 comments Download
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bigint/BigInteger.cc View 8 chunks +0 lines, -34 lines 0 comments Download
M third_party/bigint/BigInteger.hh View 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/bigint/BigIntegerUtils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/bigint/BigUnsigned.cc View 6 chunks +0 lines, -27 lines 0 comments Download
M third_party/bigint/BigUnsigned.hh View 7 chunks +0 lines, -31 lines 0 comments Download
M third_party/bigint/BigUnsignedInABase.cc View 4 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years ago (2014-12-15 20:13:39 UTC) #1
jam
Committed patchset #1 (id:1) manually as 207299b5d46e3e0612dd6a0264fb7647177312bb (presubmit successful).
6 years ago (2014-12-15 20:13:50 UTC) #2
Tom Sepez
Did you grep for additional uses of these _FX_ symbols which may only have existed ...
6 years ago (2014-12-15 20:24:53 UTC) #3
jam
6 years ago (2014-12-15 20:36:07 UTC) #4
Message was sent while issue was closed. 
On 2014/12/15 20:24:53, Tom Sepez wrote:
> Did you grep for additional uses of these _FX_ symbols which may only have
> existed in the XFA branch?  Otherwise LGTM.

good question, i only checked the foxit_chrome ifdef but not the others. looks
like there are a bunch of _FPDFAPI_MINI_ usage. i'll remove it and others in a
followup

Powered by Google App Engine
This is Rietveld 408576698