Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809483003: Update ReplacePtrsWithInts to also fix up refs from subprogram debug metadata. (Closed)

Created:
6 years ago by jvoung (off chromium)
Modified:
6 years ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update ReplacePtrsWithInts to also fix up refs from subprogram debug metadata. Cargo culted some code from the DeadArgumentElimination pass. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4023 R=mseaborn@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=3904ddc284bfd4bd1e79ca412c535742a5b4a355

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M lib/Transforms/NaCl/ReplacePtrsWithInts.cpp View 3 chunks +8 lines, -0 lines 0 comments Download
M test/Transforms/NaCl/replace-ptrs-with-ints.ll View 1 4 chunks +42 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
6 years ago (2014-12-15 22:16:46 UTC) #2
Mark Seaborn
LGTM https://codereview.chromium.org/809483003/diff/1/test/Transforms/NaCl/replace-ptrs-with-ints.ll File test/Transforms/NaCl/replace-ptrs-with-ints.ll (right): https://codereview.chromium.org/809483003/diff/1/test/Transforms/NaCl/replace-ptrs-with-ints.ll#newcode689 test/Transforms/NaCl/replace-ptrs-with-ints.ll:689: Nit: remove empty line for consistency with other ...
6 years ago (2014-12-15 23:43:27 UTC) #3
jvoung (off chromium)
Thanks! https://codereview.chromium.org/809483003/diff/1/test/Transforms/NaCl/replace-ptrs-with-ints.ll File test/Transforms/NaCl/replace-ptrs-with-ints.ll (right): https://codereview.chromium.org/809483003/diff/1/test/Transforms/NaCl/replace-ptrs-with-ints.ll#newcode689 test/Transforms/NaCl/replace-ptrs-with-ints.ll:689: On 2014/12/15 23:43:27, Mark Seaborn wrote: > Nit: ...
6 years ago (2014-12-16 01:09:10 UTC) #4
jvoung (off chromium)
6 years ago (2014-12-16 01:10:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3904ddc284bfd4bd1e79ca412c535742a5b4a355 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698