Issue 809473005: Mark printing/page-count-with-one-word.html as Pass Timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 809473005: Mark printing/page-count-with-one-word.html as Pass Timeout (Closed)

Created:
6 years ago by alex clarke (OOO till 29th)

Modified:
6 years ago

Reviewers:
rmcilroy

CC:
blink-reviews, haraken

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Mark printing/page-count-with-one-word.html as Pass Timeout Mark printing/page-count-with-one-word.html as Pass Timeout because with the blink scheduler enabled it times out on more platforms. The root cause seems to be an expensive test, it calls internals.numberOfPages 900 times (this is not a cheap call). BUG=248969, 432129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187479

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -5 lines)			Patch
M	LayoutTests/OilpanExpectations	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	LayoutTests/SlowTests	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmcilroy

On 2014/12/18 15:55:40, alexclarke1 wrote: lgtm. Please add a comment on crbug.com/248969 stating why you ...

6 years ago (2014-12-18 16:16:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809473005/1

6 years ago (2014-12-18 16:18:58 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-18 17:30:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187479

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages