Issue 809443002: Rewrite NaN checks in terms of SkScalarIsNaN()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 809443002: Rewrite NaN checks in terms of SkScalarIsNaN() (Closed)

Created:
6 years ago by ehsan

Modified:
6 years ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Rewrite NaN checks in terms of SkScalarIsNaN() We are trying to replace Skia's NaN checker with our own in Mozilla, so it would be nice to have to patch a single place by making sure these NaN checks used SkScalarIsNaN(). BUG=skia: Committed: https://skia.googlesource.com/skia/+/6f90475632b0ff8e9e83916ee6373d3c26cc9284

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	include/core/SkPoint.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/core/SkRect.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/core/SkScalar.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809443002/1

6 years ago (2014-12-15 19:59:42 UTC) #6

commit-bot: I haz the power

6 years ago (2014-12-15 20:08:52 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6f90475632b0ff8e9e83916ee6373d3c26cc9284

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages