cc: Make the PictureLayerImpl raster source null until commit.

cc: Make the PictureLayerImpl raster source null until commit.

No need to make a raster source that is never used.

R=enne, vmpstr
BUG=387116
Committed: https://crrev.com/d193f6bb5aa5bdc05e07f314abacf7d7bc466d3d
Cr-Commit-Position: refs/heads/master@{#308466}

[danakj, 2014-12-15 21:54:26]

TODO #1.

[danakj, 2014-12-15 21:55:02]

Oops, missed an upload. There we go.

[enne (OOO), 2014-12-15 22:16:18]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2014-12-15 22:16:18]

lgtm

[vmpstr, 2014-12-15 22:16:25]

lgtm

https://codereview.chromium.org/809433003/diff/20001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/809433003/diff/20001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:583: bool could_have_tilings =
raster_source_.get() && CanHaveTilings();
nit: It would be cleaner, albeit slower, if this check was a part of
CanHaveTilings. I think this is fine, but give it a thought :P

[commit-bot: I haz the power, 2014-12-15 22:17:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809433003/20001

[danakj, 2014-12-15 22:22:32]

https://codereview.chromium.org/809433003/diff/20001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/809433003/diff/20001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:583: bool could_have_tilings =
raster_source_.get() && CanHaveTilings();
On 2014/12/15 22:16:25, vmpstr wrote:
> nit: It would be cleaner, albeit slower, if this check was a part of
> CanHaveTilings. I think this is fine, but give it a thought :P

I think I prefer it here, I want to be clear that code shouldn't be null
checking this in general, if you want to use the raster source and it's not
there you're doing something wrong, which I hope this comment and single
placement conveys.

[commit-bot: I haz the power, 2014-12-16 00:06:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-16 00:07:10]

Patchset 2 (id:??) landed as
https://crrev.com/d193f6bb5aa5bdc05e07f314abacf7d7bc466d3d
Cr-Commit-Position: refs/heads/master@{#308466}