|
Revert of ES6 computed property names (patchset #9 id:160001 of https://codereview.chromium.org/795573005/)
Reason for revert:
Crashes on Win32
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1357
Test: mjsunit/harmony/computed-property-names
Flags: --stress-opt --always-opt
Command: build\Release\d8.exe --test --random-seed=-233815021 --stress-opt --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --harmony-computed-property-names test\mjsunit\mjsunit.js test\mjsunit\harmony\computed-property-names.js
Run #1
Exit code: -1073741819
Result: CRASH
Expected outcomes: PASS
Run #2
Exit code: -1073741819
Result: CRASH
Expected outcomes: PASS
Run #3
Exit code: -1073741819
Result: CRASH
Expected outcomes: PASS
Original issue's description:
> ES6 computed property names
>
> This adds support for computed property names, under the flag
> --harmony-computed-property-names, for both object literals and
> classes.
>
> BUG= v8:3754
> LOG=Y
TBR=dslomov@chromium.org,wingo@igalia.com
NOTREECHECKS=true
NOTRY=true
BUG= v8:3754
Committed: https://crrev.com/a76419f0f497db156eb1010e9b4be398951280cb
Cr-Commit-Position: refs/heads/master@{#25825}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+205 lines, -1367 lines) |
Patch |
|
M |
src/arm/full-codegen-arm.cc
|
View
|
|
5 chunks |
+8 lines, -69 lines |
0 comments
|
Download
|
|
M |
src/arm64/full-codegen-arm64.cc
|
View
|
|
5 chunks |
+8 lines, -69 lines |
0 comments
|
Download
|
|
M |
src/ast.h
|
View
|
|
3 chunks |
+19 lines, -23 lines |
0 comments
|
Download
|
|
M |
src/ast.cc
|
View
|
|
6 chunks |
+17 lines, -33 lines |
0 comments
|
Download
|
|
M |
src/ast-numbering.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/bailout-reason.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/bootstrapper.cc
|
View
|
|
3 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/builtins.h
|
View
|
|
1 chunk |
+27 lines, -28 lines |
0 comments
|
Download
|
|
M |
src/compiler/ast-graph-builder.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
src/flag-definitions.h
|
View
|
|
1 chunk |
+9 lines, -10 lines |
0 comments
|
Download
|
|
M |
src/full-codegen.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/full-codegen.cc
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/hydrogen.cc
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
|
M |
src/ia32/full-codegen-ia32.cc
|
View
|
|
4 chunks |
+8 lines, -67 lines |
0 comments
|
Download
|
|
M |
src/parser.h
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/parser.cc
|
View
|
|
5 chunks |
+7 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/preparser.h
|
View
|
|
18 chunks |
+35 lines, -100 lines |
0 comments
|
Download
|
|
M |
src/preparser.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/runtime.js
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime-classes.cc
|
View
|
|
2 chunks |
+45 lines, -1 line |
0 comments
|
Download
|
|
M |
src/runtime/runtime-object.cc
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
|
M |
src/typing.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
src/x64/full-codegen-x64.cc
|
View
|
|
4 chunks |
+8 lines, -67 lines |
0 comments
|
Download
|
|
M |
test/cctest/test-parsing.cc
|
View
|
|
3 chunks |
+1 line, -62 lines |
0 comments
|
Download
|
|
D |
test/mjsunit/harmony/computed-property-names.js
|
View
|
|
1 chunk |
+0 lines, -270 lines |
0 comments
|
Download
|
|
D |
test/mjsunit/harmony/computed-property-names-classes.js
|
View
|
|
1 chunk |
+0 lines, -367 lines |
0 comments
|
Download
|
|
D |
test/mjsunit/harmony/computed-property-names-object-literals-methods.js
|
View
|
|
1 chunk |
+0 lines, -121 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|