tools/telemetry/telemetry/value/improvement_direction.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/improvement_direction.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/value/histogram_unittest.py ('k') | tools/telemetry/telemetry/value/list_of_scalar_values.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/value/improvement_direction.py

diff --git a/third_party/ashmem/BUILD.gn b/tools/telemetry/telemetry/value/improvement_direction.py

similarity index 61%

copy from third_party/ashmem/BUILD.gn

copy to tools/telemetry/telemetry/value/improvement_direction.py

index a3f7e6a28657131501024ba45b28627ae0893fff..eea76f1e7a738ab42479bacbab0741abea4dcd53 100644

--- a/third_party/ashmem/BUILD.gn

+++ b/tools/telemetry/telemetry/value/improvement_direction.py

@@ -2,11 +2,8 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-assert(is_android)

+UP = 'up'

+DOWN = 'down'

-source_set("ashmem") {

- sources = [

- "ashmem.h",

- "ashmem-dev.c",

- ]

+def IsValid(improvement_direction):

+ return improvement_direction in [UP, DOWN]