Added support for improvement_direction to relevant values, which is propogated to chartjson.

tools/telemetry/telemetry/results/csv_output_formatter_unittest.py

Index: tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py b/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
index 1aac38c17bbfabf06164052f6a8a831513c72808..b0a08c8fa4a206ebadc574c0e7bbdd84577d3f52 100644
--- a/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
@@ -11,6 +11,7 @@ from telemetry.page import page_set
 from telemetry.results import csv_output_formatter
 from telemetry.results import page_test_results
 from telemetry.value import histogram
+from telemetry.value import improvement_direction
 from telemetry.value import scalar
 
 
@@ -45,7 +46,9 @@ class CsvOutputFormatterTest(unittest.TestCase):
   def test_with_no_results_on_second_run(self):
     results = page_test_results.PageTestResults()
     results.WillRunPage(self._page_set[0])
-    results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
+    results.AddValue(scalar.ScalarValue(
+        self._page_set[0], 'foo', 'seconds', 3,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(self._page_set[0])
 
     results.WillRunPage(self._page_set[1])
@@ -62,12 +65,18 @@ class CsvOutputFormatterTest(unittest.TestCase):
   def test_fewer_results_on_second_run(self):
     results = page_test_results.PageTestResults()
     results.WillRunPage(self._page_set[0])
-    results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
-    results.AddValue(scalar.ScalarValue(self._page_set[0], 'bar', 'seconds', 4))
+    results.AddValue(scalar.ScalarValue(
+        self._page_set[0], 'foo', 'seconds', 3,
+        improvement_direction=improvement_direction.DOWN))
+    results.AddValue(scalar.ScalarValue(
+        self._page_set[0], 'bar', 'seconds', 4,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(self._page_set[0])
 
     results.WillRunPage(self._page_set[1])
-    results.AddValue(scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 5))
+    results.AddValue(scalar.ScalarValue(
+        self._page_set[1], 'bar', 'seconds', 5,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(self._page_set[1])
 
     self._formatter.Format(results)
@@ -80,11 +89,15 @@ class CsvOutputFormatterTest(unittest.TestCase):
   def test_with_output_at_print_summary_time(self):
     results = page_test_results.PageTestResults()
     results.WillRunPage(self._page_set[0])
-    results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
+    results.AddValue(scalar.ScalarValue(
+        self._page_set[0], 'foo', 'seconds', 3,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(self._page_set[0])
 
     results.WillRunPage(self._page_set[1])
-    results.AddValue(scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 4))
+    results.AddValue(scalar.ScalarValue(
+        self._page_set[1], 'bar', 'seconds', 4,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(self._page_set[1])
 
     self._formatter.Format(results)
@@ -102,13 +115,15 @@ class CsvOutputFormatterTest(unittest.TestCase):
     results.WillRunPage(self._page_set[0])
     results.AddValue(histogram.HistogramValue(
         self._page_set[0], 'a', '',
-        raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}'))
+        raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
+        improvement_direction=improvement_direction.UP))
     results.DidRunPage(self._page_set[0])
 
     results.WillRunPage(self._page_set[1])
     results.AddValue(histogram.HistogramValue(
         self._page_set[1], 'a', '',
-        raw_value_json='{"buckets": [{"low": 2, "high": 3, "count": 1}]}'))
+        raw_value_json='{"buckets": [{"low": 2, "high": 3, "count": 1}]}',
+        improvement_direction=improvement_direction.UP))
     results.DidRunPage(self._page_set[1])
 
     self._formatter.Format(results)