Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: tools/perf/metrics/webrtc_stats.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/webrtc_stats.py
diff --git a/tools/perf/metrics/webrtc_stats.py b/tools/perf/metrics/webrtc_stats.py
index 4a787dd1afa16d87a8e5a9cda6d7a0cb689ad6ec..b6414105348fc85475a02a829f441c2c4518bf79 100644
--- a/tools/perf/metrics/webrtc_stats.py
+++ b/tools/perf/metrics/webrtc_stats.py
@@ -8,24 +8,29 @@ import re
from metrics import Metric
from telemetry.core import camel_case
+from telemetry.value import improvement_direction
from telemetry.value import list_of_scalar_values
INTERESTING_METRICS = {
'packetsReceived': {
'units': 'packets',
'description': 'Packets received by the peer connection',
+ 'improvement_direction': improvement_direction.DOWN,
},
'packetsSent': {
'units': 'packets',
'description': 'Packets sent by the peer connection',
+ 'improvement_direction': improvement_direction.DOWN,
},
'googDecodeMs': {
'units': 'ms',
'description': 'Time spent decoding.',
+ 'improvement_direction': improvement_direction.DOWN,
},
'googMaxDecodeMs': {
'units': 'ms',
'description': 'Maximum time spent decoding one frame.',
+ 'improvement_direction': improvement_direction.DOWN,
},
# TODO(phoglund): Add much more interesting metrics.
}
@@ -98,4 +103,6 @@ class WebRtcStatisticsMetric(Metric):
results.current_page, trace_name,
INTERESTING_METRICS[general_name]['units'], values,
description=INTERESTING_METRICS[general_name]['description'],
- important=False))
+ important=False,
+ improvement_direction=INTERESTING_METRICS[
+ general_name]['improvement_direction']))

Powered by Google App Engine
This is Rietveld 408576698