tools/perf/metrics/system_memory.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/system_memory.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/system_memory.py

diff --git a/tools/perf/metrics/system_memory.py b/tools/perf/metrics/system_memory.py

index 6909d16a4f73efe8791fb219b7bf525ccc49ea43..745dcd475219b0cb0f5bd50da606012f4d3a93c9 100644

--- a/tools/perf/metrics/system_memory.py

+++ b/tools/perf/metrics/system_memory.py

@@ -4,6 +4,7 @@

from metrics import memory

from metrics import Metric

+from telemetry.value import improvement_direction

from telemetry.value import scalar

@@ -64,13 +65,15 @@ class SystemMemoryMetric(Metric):

results.AddValue(scalar.ScalarValue(

results.current_page,

'commit_charge_delta.%s' % (trace_name or 'commit_charge'), 'kb',

- memory_stats['SystemCommitCharge'], important=False))

+ memory_stats['SystemCommitCharge'], important=False,

+ improvement_direction=improvement_direction.DOWN))

if 'ProcessCount' not in exclude_metrics:

results.AddValue(scalar.ScalarValue(

results.current_page,

'processes_delta.%s' % (trace_name or 'processes'), 'count',

- memory_stats['ProcessCount'], important=False))

+ memory_stats['ProcessCount'], important=False,

+ improvement_direction=improvement_direction.DOWN))

def _SubtractMemoryStats(end_memory_stats, start_memory_stats):

« no previous file with comments | « tools/perf/metrics/startup_metric.py ('k') | tools/perf/metrics/timeline.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')