tools/perf/benchmarks/spaceport.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/spaceport.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/spaceport.py

diff --git a/tools/perf/benchmarks/spaceport.py b/tools/perf/benchmarks/spaceport.py

index 5837a06b6cee40c7c5f8e845b220460980051b85..c5d0f230a2970f2855d0723cdb609bc219a0610f 100644

--- a/tools/perf/benchmarks/spaceport.py

+++ b/tools/perf/benchmarks/spaceport.py

@@ -12,6 +12,7 @@ from telemetry import page as page_module

from telemetry.core import util

from telemetry.page import page_set

from telemetry.page import page_test

+from telemetry.value import improvement_direction

from telemetry.value import list_of_scalar_values

from telemetry.value import scalar

@@ -91,7 +92,8 @@ class _SpaceportMeasurement(page_test.PageTest):

results.AddValue(list_of_scalar_values.ListOfScalarValues(

results.current_page, 'Score', 'objects (bigger is better)',

[float(x) for x in result_dict.values()],

- description='Combined score for all parts of the spaceport benchmark.'))

+ description='Combined score for all parts of the spaceport benchmark.',

+ improvement_direction=improvement_direction.UP))

# crbug.com/166703: This test frequently times out on Windows.

« no previous file with comments | « tools/perf/benchmarks/service_worker.py ('k') | tools/perf/benchmarks/speedometer.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')