Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2068)

Unified Diff: tools/telemetry/telemetry/value/value_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/value_unittest.py
diff --git a/tools/telemetry/telemetry/value/value_unittest.py b/tools/telemetry/telemetry/value/value_unittest.py
index 69e48d918c181b07f356c63a1445002fa18bab49..b793dfc0143e5f286b7eea98d18d3a7d8b86a39b 100644
--- a/tools/telemetry/telemetry/value/value_unittest.py
+++ b/tools/telemetry/telemetry/value/value_unittest.py
@@ -92,14 +92,17 @@ class ValueTest(TestBase):
self.assertFalse(b.IsMergableWith(a))
def testAsDictBaseKeys(self):
- v = ValueForAsDictTest(None, 'x', 'unit', important=True, description=None)
+ v = ValueForAsDictTest(
+ None, 'x', 'unit', important=True, description=None,
+ higher_is_better=True)
d = v.AsDict()
self.assertEquals(d, {
'name': 'x',
'type': 'baz',
'units': 'unit',
- 'important': True
+ 'important': True,
+ 'higher_is_better': True,
})
def testAsDictWithPage(self):
@@ -131,13 +134,15 @@ class ValueTest(TestBase):
d = {
'type': 'value_for_from_dict_test',
'name': 'x',
- 'units': 'unit'
+ 'units': 'unit',
+ 'higher_is_better': True
}
v = value.Value.FromDict(d, None)
self.assertEquals(v.name, 'x')
self.assertTrue(isinstance(v, ValueForFromDictTest))
self.assertEquals(v.units, 'unit')
+ self.assertTrue(v.higher_is_better)
def testFromDictWithPage(self):
page0 = self.pages[0]

Powered by Google App Engine
This is Rietveld 408576698