Index: tools/telemetry/telemetry/value/scalar_unittest.py |
diff --git a/tools/telemetry/telemetry/value/scalar_unittest.py b/tools/telemetry/telemetry/value/scalar_unittest.py |
index 14abd21818e742020bdae11b7b2ce3a98d72ae57..24ad641620a01f75419dc717e38bf164353b786d 100644 |
--- a/tools/telemetry/telemetry/value/scalar_unittest.py |
+++ b/tools/telemetry/telemetry/value/scalar_unittest.py |
@@ -40,8 +40,8 @@ class ValueTest(TestBase): |
def testScalarSamePageMerging(self): |
page0 = self.pages[0] |
- v0 = scalar.ScalarValue(page0, 'x', 'unit', 1) |
- v1 = scalar.ScalarValue(page0, 'x', 'unit', 2) |
+ v0 = scalar.ScalarValue(page0, 'x', 'unit', 1, higher_is_better=True) |
+ v1 = scalar.ScalarValue(page0, 'x', 'unit', 2, higher_is_better=True) |
self.assertTrue(v1.IsMergableWith(v0)) |
vM = scalar.ScalarValue.MergeLikeValuesFromSamePage([v0, v1]) |
@@ -50,6 +50,7 @@ class ValueTest(TestBase): |
self.assertEquals('unit', vM.units) |
self.assertEquals(True, vM.important) |
self.assertEquals([1, 2], vM.values) |
+ self.assertEquals(True, vM.higher_is_better) |
def testScalarDifferentPageMerging(self): |
page0 = self.pages[0] |
@@ -63,6 +64,7 @@ class ValueTest(TestBase): |
self.assertEquals('unit', vM.units) |
self.assertEquals(True, vM.important) |
self.assertEquals([1, 2], vM.values) |
+ self.assertEquals(None, vM.higher_is_better) |
def testScalarWithNoneValueMerging(self): |
page0 = self.pages[0] |
@@ -109,13 +111,15 @@ class ValueTest(TestBase): |
'type': 'scalar', |
'name': 'x', |
'units': 'unit', |
- 'value': 42 |
+ 'value': 42, |
+ 'higher_is_better': False |
} |
v = value.Value.FromDict(d, {}) |
self.assertTrue(isinstance(v, scalar.ScalarValue)) |
self.assertEquals(v.value, 42) |
+ self.assertEquals(False, v.higher_is_better) |
def testFromDictFloat(self): |
d = { |