tools/telemetry/telemetry/value/merge_values_unittest.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/merge_values_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/value/__init__.py ('K') | « tools/telemetry/telemetry/value/list_of_scalar_values.py ('k') | tools/telemetry/telemetry/value/scalar.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/value/merge_values_unittest.py

diff --git a/tools/telemetry/telemetry/value/merge_values_unittest.py b/tools/telemetry/telemetry/value/merge_values_unittest.py

index 4633efc7cc3dea245f71eae8b4b4589fcd3f024a..9bec41edcacea240104fbba7bb92ffa3eade60cd 100644

--- a/tools/telemetry/telemetry/value/merge_values_unittest.py

+++ b/tools/telemetry/telemetry/value/merge_values_unittest.py

@@ -28,10 +28,11 @@ class MergeValueTest(TestBase):

page0 = self.pages[0]

page1 = self.pages[1]

- all_values = [scalar.ScalarValue(page0, 'x', 'units', 1),

- scalar.ScalarValue(page1, 'x', 'units', 4),

- scalar.ScalarValue(page0, 'x', 'units', 2),

- scalar.ScalarValue(page1, 'x', 'units', 5)]

+ all_values = [

+ scalar.ScalarValue(page0, 'x', 'units', 1, higher_is_better=True),

+ scalar.ScalarValue(page1, 'x', 'units', 4, higher_is_better=True),

+ scalar.ScalarValue(page0, 'x', 'units', 2, higher_is_better=True),

+ scalar.ScalarValue(page1, 'x', 'units', 5, higher_is_better=True)]

merged_values = merge_values.MergeLikeValuesFromSamePage(all_values)

# Sort the results so that their order is predictable for the subsequent

@@ -47,6 +48,7 @@ class MergeValueTest(TestBase):

self.assertEquals((page1, 'x'),

(merged_values[1].page, merged_values[1].name))

self.assertEquals([4, 5], merged_values[1].values)

+ self.assertTrue(merged_values[0].higher_is_better)

def testSamePageMergeOneValue(self):

page0 = self.pages[0]