Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: tools/telemetry/telemetry/value/failure.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/failure.py
diff --git a/tools/telemetry/telemetry/value/failure.py b/tools/telemetry/telemetry/value/failure.py
index 3b51b61c7d89f914660a4ca4532d2747801519ae..e8078fdbd5f95034676a33533351c2009b42cfbe 100644
--- a/tools/telemetry/telemetry/value/failure.py
+++ b/tools/telemetry/telemetry/value/failure.py
@@ -81,9 +81,10 @@ class FailureValue(value_module.Value):
kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
del kwargs['name']
del kwargs['units']
- important = kwargs.get('important', None)
- if important != None:
+ if 'important' in kwargs:
del kwargs['important']
+ if 'higher_is_better' in kwargs:
+ del kwargs['higher_is_better']
kwargs['exc_info'] = FailureValue._GetExcInfoFromMessage(
value_dict['value'])

Powered by Google App Engine
This is Rietveld 408576698