tools/perf/metrics/v8_object_stats.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/v8_object_stats.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/v8_object_stats.py

diff --git a/tools/perf/metrics/v8_object_stats.py b/tools/perf/metrics/v8_object_stats.py

index a085125a91769440be4034be183b29a1518ea911..ecaad4ec868f143e1bf1f84fab737725d16dee67 100644

--- a/tools/perf/metrics/v8_object_stats.py

+++ b/tools/perf/metrics/v8_object_stats.py

@@ -230,4 +230,5 @@ class V8ObjectStatsMetric(Metric):

display_name = counter_name.replace('.', '_')

results.AddValue(scalar.ScalarValue(

results.current_page, display_name, 'kb',

- self._results[counter_name] / 1024.0, description=description))

+ self._results[counter_name] / 1024.0, description=description,

+ higher_is_better=False))

« tools/perf/benchmarks/dom_perf.py ('K') | « tools/perf/metrics/timeline.py ('k') | tools/perf/metrics/webrtc_stats.py » ('j') | tools/telemetry/telemetry/value/__init__.py » ('J')