Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: tools/perf/benchmarks/spaceport.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/spaceport.py
diff --git a/tools/perf/benchmarks/spaceport.py b/tools/perf/benchmarks/spaceport.py
index ec46ffb605388b837bea2f1d4e547dc794833e42..db2fca6643cd74cb183e4d56cd0c4a58f77485c9 100644
--- a/tools/perf/benchmarks/spaceport.py
+++ b/tools/perf/benchmarks/spaceport.py
@@ -86,11 +86,13 @@ class _SpaceportMeasurement(page_test.PageTest):
results.AddValue(scalar.ScalarValue(
results.current_page, '%s.%s'% (chart, trace),
'objects (bigger is better)', float(result_dict[key]),
- important=False, description=DESCRIPTIONS.get(chart)))
+ important=False, description=DESCRIPTIONS.get(chart),
+ higher_is_better=True))
results.AddValue(list_of_scalar_values.ListOfScalarValues(
results.current_page, 'Score', 'objects (bigger is better)',
[float(x) for x in result_dict.values()],
- description='Combined score for all parts of the spaceport benchmark.'))
+ description='Combined score for all parts of the spaceport benchmark.',
+ higher_is_better=True))
# crbug.com/166703: This test frequently times out on Windows.

Powered by Google App Engine
This is Rietveld 408576698