OLD | NEW |
1 # Copyright 2013 The Chromium Authors. All rights reserved. | 1 # Copyright 2013 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 import json | 5 import json |
6 import logging | 6 import logging |
7 | 7 |
8 from metrics import Metric | 8 from metrics import Metric |
| 9 from telemetry.value import improvement_direction |
9 from telemetry.value import scalar | 10 from telemetry.value import scalar |
10 | 11 |
11 | 12 |
12 _COUNTER_NAMES = [ | 13 _COUNTER_NAMES = [ |
13 'V8.OsMemoryAllocated', | 14 'V8.OsMemoryAllocated', |
14 'V8.MemoryNewSpaceBytesAvailable', | 15 'V8.MemoryNewSpaceBytesAvailable', |
15 'V8.MemoryNewSpaceBytesCommitted', | 16 'V8.MemoryNewSpaceBytesCommitted', |
16 'V8.MemoryNewSpaceBytesUsed', | 17 'V8.MemoryNewSpaceBytesUsed', |
17 'V8.MemoryOldPointerSpaceBytesAvailable', | 18 'V8.MemoryOldPointerSpaceBytesAvailable', |
18 'V8.MemoryOldPointerSpaceBytesCommitted', | 19 'V8.MemoryOldPointerSpaceBytesCommitted', |
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
223 logging.warning('No V8 object stats from website: ' + page.display_name) | 224 logging.warning('No V8 object stats from website: ' + page.display_name) |
224 | 225 |
225 def AddResults(self, tab, results): | 226 def AddResults(self, tab, results): |
226 """Add results for this page to the results object.""" | 227 """Add results for this page to the results object.""" |
227 assert self._results != None, 'Must call Stop() first' | 228 assert self._results != None, 'Must call Stop() first' |
228 for counter_name in self._results: | 229 for counter_name in self._results: |
229 description = DESCRIPTIONS.get(counter_name) | 230 description = DESCRIPTIONS.get(counter_name) |
230 display_name = counter_name.replace('.', '_') | 231 display_name = counter_name.replace('.', '_') |
231 results.AddValue(scalar.ScalarValue( | 232 results.AddValue(scalar.ScalarValue( |
232 results.current_page, display_name, 'kb', | 233 results.current_page, display_name, 'kb', |
233 self._results[counter_name] / 1024.0, description=description)) | 234 self._results[counter_name] / 1024.0, description=description, |
| 235 improvement_direction=improvement_direction.DOWN)) |
OLD | NEW |