Added support for improvement_direction to relevant values, which is propogated to chartjson.

tools/perf/measurements/oilpan_gc_times.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 from measurements import smoothness_controller
 from measurements import timeline_controller
 from telemetry.core.platform import tracing_category_filter
 from telemetry.core.platform import tracing_options
 from telemetry.page import page_test
 from telemetry.page.actions import action_runner
 from telemetry.timeline.model import TimelineModel
 from telemetry.util import statistics
+from telemetry.value import improvement_direction
 from telemetry.value import list_of_scalar_values
 from telemetry.value import scalar
 from telemetry.value import trace
 
 
 _CR_RENDERER_MAIN = 'CrRendererMain'
 _RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions'
 _NAMES_TO_DUMP = ['oilpan_precise_mark',
                   'oilpan_precise_sweep',
                   'oilpan_conservative_mark',
@@ skipping 33 matching lines @@
   if not gc_type is None and not forced:
     values['oilpan_%s_mark' % gc_type].append(mark_time)
     values['oilpan_%s_sweep' % gc_type].append(sweep_time)
 
   # Dump
   page = results.current_page
   unit = 'ms'
   for name in _NAMES_TO_DUMP:
     if values[name]:
       results.AddValue(list_of_scalar_values.ListOfScalarValues(
-          page, name, unit, values[name]))
+          page, name, unit, values[name],
+          improvement_direction=improvement_direction.DOWN))
       results.AddValue(scalar.ScalarValue(
-          page, name + '_max', unit, max(values[name])))
+          page, name + '_max', unit, max(values[name]),
+          improvement_direction=improvement_direction.DOWN))
     results.AddValue(scalar.ScalarValue(
-        page, name + '_total', unit, sum(values[name])))
+        page, name + '_total', unit, sum(values[name]),
+        improvement_direction=improvement_direction.DOWN))
 
   for do_type in ['mark', 'sweep']:
     work_time = 0
     for gc_type in ['precise', 'conservative']:
       work_time += sum(values['oilpan_%s_%s' % (gc_type, do_type)])
     key = 'oilpan_%s' % do_type
-    results.AddValue(scalar.ScalarValue(page, key, unit, work_time))
+    results.AddValue(scalar.ScalarValue(page, key, unit, work_time,
+                     improvement_direction=improvement_direction.DOWN))
 
   gc_time = 0
   for key in values:
     gc_time += sum(values[key])
-  results.AddValue(scalar.ScalarValue(page, 'oilpan_gc', unit, gc_time))
+  results.AddValue(scalar.ScalarValue(
+      page, 'oilpan_gc', unit, gc_time,
+      improvement_direction=improvement_direction.DOWN))
 
 
 class _OilpanGCTimesBase(page_test.PageTest):
   def __init__(self, action_name = ''):
     super(_OilpanGCTimesBase, self).__init__(action_name)
     self._timeline_model = None
 
   def WillNavigateToPage(self, page, tab):
     # FIXME: Remove webkit.console when blink.console lands in chromium and
     # the ref builds are updated. crbug.com/386847
@@ skipping 54 matching lines @@
 
 class OilpanGCTimesForInternals(_OilpanGCTimesBase):
   def __init__(self):
     super(OilpanGCTimesForInternals, self).__init__()
 
   @classmethod
   def CustomizeBrowserOptions(cls, options):
     # 'expose-internals-for-testing' can be enabled on content shell.
     assert 'content-shell' in options.browser_type
     options.AppendExtraBrowserArgs('--expose-internals-for-testing')