Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: tools/perf/benchmarks/robohornet_pro.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Runs Microsoft's RoboHornet Pro benchmark.""" 5 """Runs Microsoft's RoboHornet Pro benchmark."""
6 6
7 import os 7 import os
8 8
9 from metrics import power 9 from metrics import power
10 from telemetry import benchmark 10 from telemetry import benchmark
11 from telemetry import page as page_module 11 from telemetry import page as page_module
12 from telemetry.page import page_set 12 from telemetry.page import page_set
13 from telemetry.page import page_test 13 from telemetry.page import page_test
14 from telemetry.value import improvement_direction
14 from telemetry.value import scalar 15 from telemetry.value import scalar
15 16
16 17
17 class _RobohornetProMeasurement(page_test.PageTest): 18 class _RobohornetProMeasurement(page_test.PageTest):
18 def __init__(self): 19 def __init__(self):
19 super(_RobohornetProMeasurement, self).__init__( 20 super(_RobohornetProMeasurement, self).__init__(
20 action_name_to_run='RunPageInteractions') 21 action_name_to_run='RunPageInteractions')
21 self._power_metric = None 22 self._power_metric = None
22 23
23 def CustomizeBrowserOptions(self, options): 24 def CustomizeBrowserOptions(self, options):
24 power.PowerMetric.CustomizeBrowserOptions(options) 25 power.PowerMetric.CustomizeBrowserOptions(options)
25 26
26 def WillStartBrowser(self, platform): 27 def WillStartBrowser(self, platform):
27 self._power_metric = power.PowerMetric(platform) 28 self._power_metric = power.PowerMetric(platform)
28 29
29 def DidNavigateToPage(self, page, tab): 30 def DidNavigateToPage(self, page, tab):
30 self._power_metric.Start(page, tab) 31 self._power_metric.Start(page, tab)
31 32
32 def ValidateAndMeasurePage(self, page, tab, results): 33 def ValidateAndMeasurePage(self, page, tab, results):
33 tab.ExecuteJavaScript('ToggleRoboHornet()') 34 tab.ExecuteJavaScript('ToggleRoboHornet()')
34 tab.WaitForJavaScriptExpression( 35 tab.WaitForJavaScriptExpression(
35 'document.getElementById("results").innerHTML.indexOf("Total") != -1', 36 'document.getElementById("results").innerHTML.indexOf("Total") != -1',
36 600) 37 600)
37 38
38 self._power_metric.Stop(page, tab) 39 self._power_metric.Stop(page, tab)
39 self._power_metric.AddResults(tab, results) 40 self._power_metric.AddResults(tab, results)
40 41
41 result = int(tab.EvaluateJavaScript('stopTime - startTime')) 42 result = int(tab.EvaluateJavaScript('stopTime - startTime'))
42 results.AddValue( 43 results.AddValue(
43 scalar.ScalarValue(results.current_page, 'Total', 'ms', result)) 44 scalar.ScalarValue(results.current_page, 'Total', 'ms', result,
45 improvement_direction=improvement_direction.DOWN))
44 46
45 47
46 # We plan to remove this test because it doesn't give useful data, but 48 # We plan to remove this test because it doesn't give useful data, but
47 # we need to wait until Chrome OS can implement support for more helpful 49 # we need to wait until Chrome OS can implement support for more helpful
48 # benchmarks. 50 # benchmarks.
49 @benchmark.Enabled('chromeos') 51 @benchmark.Enabled('chromeos')
50 class RobohornetPro(benchmark.Benchmark): 52 class RobohornetPro(benchmark.Benchmark):
51 """Milliseconds to complete the RoboHornetPro demo by Microsoft. 53 """Milliseconds to complete the RoboHornetPro demo by Microsoft.
52 54
53 http://ie.microsoft.com/testdrive/performance/robohornetpro/ 55 http://ie.microsoft.com/testdrive/performance/robohornetpro/
54 """ 56 """
55 test = _RobohornetProMeasurement 57 test = _RobohornetProMeasurement
56 58
57 def CreatePageSet(self, options): 59 def CreatePageSet(self, options):
58 ps = page_set.PageSet( 60 ps = page_set.PageSet(
59 archive_data_file='../page_sets/data/robohornet_pro.json', 61 archive_data_file='../page_sets/data/robohornet_pro.json',
60 file_path=os.path.abspath(__file__), 62 file_path=os.path.abspath(__file__),
61 bucket=page_set.PARTNER_BUCKET) 63 bucket=page_set.PARTNER_BUCKET)
62 ps.AddUserStory(page_module.Page( 64 ps.AddUserStory(page_module.Page(
63 'http://ie.microsoft.com/testdrive/performance/robohornetpro/', 65 'http://ie.microsoft.com/testdrive/performance/robohornetpro/',
64 ps, ps.base_dir, 66 ps, ps.base_dir,
65 # Measurement require use of real Date.now() for measurement. 67 # Measurement require use of real Date.now() for measurement.
66 make_javascript_deterministic=False)) 68 make_javascript_deterministic=False))
67 return ps 69 return ps
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698