Added support for improvement_direction to relevant values, which is propogated to chartjson.

tools/perf/metrics/memory.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 
 from metrics import Metric
 from telemetry.value import histogram
 from telemetry.value import histogram_util
 from telemetry.value import scalar
 
 
 _HISTOGRAMS = [
     {
         'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent',
         'display_name': 'V8_MemoryExternalFragmentationTotal',
         'type': histogram_util.RENDERER_HISTOGRAM,
         'description': 'Total external memory fragmentation after each GC in '
                        'percent.',
+        'higher_is_better': False,
     },
     {
         'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb',
         'display_name': 'V8_MemoryHeapSampleTotalCommitted',
         'type': histogram_util.RENDERER_HISTOGRAM,
         'description': 'The total size of committed memory used by V8 after '
-                       'each GC in KB.'
+                       'each GC in KB.',
+        'higher_is_better': False,
     },
     {
         'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb',
         'display_name': 'V8_MemoryHeapSampleTotalUsed',
         'type': histogram_util.RENDERER_HISTOGRAM,
         'description': 'The total size of live memory used by V8 after each '
                        'GC in KB.',
+        'higher_is_better': False,
     },
     {
         'name': 'V8.MemoryHeapSampleMaximumCommitted', 'units': 'kb',
         'display_name': 'V8_MemoryHeapSampleMaximumCommitted',
-        'type': histogram_util.RENDERER_HISTOGRAM
+        'type': histogram_util.RENDERER_HISTOGRAM,
+        'higher_is_better': False,
     },
     {
         'name': 'Memory.RendererUsed', 'units': 'kb',
         'display_name': 'Memory_RendererUsed',
-        'type': histogram_util.RENDERER_HISTOGRAM
+        'type': histogram_util.RENDERER_HISTOGRAM,
+        'higher_is_better': False,
     },
     {
         'name': 'Memory.BrowserUsed', 'units': 'kb',
         'display_name': 'Memory_BrowserUsed',
-        'type': histogram_util.BROWSER_HISTOGRAM
+        'type': histogram_util.BROWSER_HISTOGRAM,
+        'higher_is_better': False,
     },
 ]
 
 class MemoryMetric(Metric):
   """MemoryMetric gathers memory statistics from the browser object.
 
   This includes both per-page histogram stats, most about javascript
   memory usage, and overall memory stats from the system for the whole
   test run."""
 
@@ skipping 55 matching lines @@
   def AddResults(self, tab, results, trace_name=None):
     """Add results for this page to the results object."""
     assert self._histogram_delta, 'Must call Stop() first'
     for h in _HISTOGRAMS:
       # Histogram data may not be available
       if h['name'] not in self._histogram_start:
         continue
       results.AddValue(histogram.HistogramValue(
           results.current_page, h['display_name'], h['units'],
           raw_value_json=self._histogram_delta[h['name']], important=False,
-          description=h.get('description')))
+          description=h.get('description'),
+          higher_is_better=h.get('higher_is_better')))
     self._memory_stats = self._browser.memory_stats
     if not self._memory_stats['Browser']:
       return
     AddResultsForProcesses(results, self._memory_stats,
                            metric_trace_name=trace_name)
 
     if self._start_commit_charge:
       end_commit_charge = self._memory_stats['SystemCommitCharge']
       commit_charge_difference = end_commit_charge - self._start_commit_charge
       results.AddValue(scalar.ScalarValue(
           results.current_page,
           'commit_charge.' + (trace_name or 'commit_charge'),
           'kb', commit_charge_difference, important=False,
-          description='System commit charge (committed memory pages).'))
+          description='System commit charge (committed memory pages).',
+          higher_is_better=False))
     results.AddValue(scalar.ScalarValue(
         results.current_page, 'processes.' + (trace_name or 'processes'),
         'count', self._memory_stats['ProcessCount'], important=False,
-        description='Number of processes used by Chrome.'))
+        description='Number of processes used by Chrome.',
+        higher_is_better=False))
 
 
 def AddResultsForProcesses(results, memory_stats, chart_trace_name='final',
                            metric_trace_name=None,
                            exclude_metrics=None):
   """Adds memory stats for browser, renderer and gpu processes.
 
   Args:
     results: A telemetry.results.PageTestResults object.
     memory_stats: System memory stats collected.
@@ skipping 33 matching lines @@
           values.append(stats[value_name_memory])
       if values:
         if metric_trace_name:
           current_trace = '%s_%s' % (metric_trace_name, process_type_trace)
           chart_name = value_name_trace
         else:
           current_trace = '%s_%s' % (value_name_trace, process_type_trace)
           chart_name = current_trace
         results.AddValue(scalar.ScalarValue(
             results.current_page, '%s.%s' % (chart_name, current_trace), 'kb',
-            sum(values) / 1024, important=False, description=description))
+            sum(values) / 1024, important=False, description=description,
+            higher_is_better=False))
 
     AddResult('VM', 'vm_%s_size' % chart_trace_name,
               'Virtual Memory Size (address space allocated).')
     AddResult('WorkingSetSize', 'vm_%s_%s_size' % (metric, chart_trace_name),
               'Working Set Size (Windows) or Resident Set Size (other '
               'platforms).')
     AddResult('PrivateDirty', 'vm_private_dirty_%s' % chart_trace_name,
               'Private Dirty is basically the amount of RAM inside the '
               'process that can not be paged to disk (it is not backed by the '
               'same data on disk), and is not shared with any other '
@@ skipping 16 matching lines @@
     AddResult('VMPeak', 'vm_peak_size',
               'The peak Virtual Memory Size (address space allocated) usage '
               'achieved by the * process.')
     AddResult('WorkingSetSizePeak', '%s_peak_size' % metric,
               'Peak Working Set Size.')
 
   AddResultsForProcessTypes(['Browser'], 'browser')
   AddResultsForProcessTypes(['Renderer'], 'renderer')
   AddResultsForProcessTypes(['Gpu'], 'gpu')
   AddResultsForProcessTypes(['Browser', 'Renderer', 'Gpu'], 'total')