Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: tools/perf/metrics/loading.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import Metric 5 from metrics import Metric
6 from telemetry.value import scalar 6 from telemetry.value import scalar
7 7
8 class LoadingMetric(Metric): 8 class LoadingMetric(Metric):
9 """A metric for page loading time based entirely on window.performance""" 9 """A metric for page loading time based entirely on window.performance"""
10 10
11 def Start(self, page, tab): 11 def Start(self, page, tab):
12 raise NotImplementedError() 12 raise NotImplementedError()
13 13
14 def Stop(self, page, tab): 14 def Stop(self, page, tab):
15 raise NotImplementedError() 15 raise NotImplementedError()
16 16
17 def AddResults(self, tab, results): 17 def AddResults(self, tab, results):
18 load_timings = tab.EvaluateJavaScript('window.performance.timing') 18 load_timings = tab.EvaluateJavaScript('window.performance.timing')
19 19
20 # NavigationStart relative markers in milliseconds. 20 # NavigationStart relative markers in milliseconds.
21 load_start = ( 21 load_start = (
22 float(load_timings['loadEventStart']) - load_timings['navigationStart']) 22 float(load_timings['loadEventStart']) - load_timings['navigationStart'])
23 results.AddValue(scalar.ScalarValue( 23 results.AddValue(scalar.ScalarValue(
24 results.current_page, 'load_start', 'ms', load_start)) 24 results.current_page, 'load_start', 'ms', load_start,
25 higher_is_better=False))
25 26
26 dom_content_loaded_start = ( 27 dom_content_loaded_start = (
27 float(load_timings['domContentLoadedEventStart']) - 28 float(load_timings['domContentLoadedEventStart']) -
28 load_timings['navigationStart']) 29 load_timings['navigationStart'])
29 results.AddValue(scalar.ScalarValue( 30 results.AddValue(scalar.ScalarValue(
30 results.current_page, 'dom_content_loaded_start', 'ms', 31 results.current_page, 'dom_content_loaded_start', 'ms',
31 dom_content_loaded_start)) 32 dom_content_loaded_start, higher_is_better=False))
32 33
33 fetch_start = ( 34 fetch_start = (
34 float(load_timings['fetchStart']) - load_timings['navigationStart']) 35 float(load_timings['fetchStart']) - load_timings['navigationStart'])
35 results.AddValue(scalar.ScalarValue( 36 results.AddValue(scalar.ScalarValue(
36 results.current_page, 'fetch_start', 'ms', fetch_start, 37 results.current_page, 'fetch_start', 'ms', fetch_start,
37 important=False)) 38 important=False, higher_is_better=False))
38 39
39 request_start = ( 40 request_start = (
40 float(load_timings['requestStart']) - load_timings['navigationStart']) 41 float(load_timings['requestStart']) - load_timings['navigationStart'])
41 results.AddValue(scalar.ScalarValue( 42 results.AddValue(scalar.ScalarValue(
42 results.current_page, 'request_start', 'ms', request_start, 43 results.current_page, 'request_start', 'ms', request_start,
43 important=False)) 44 important=False, higher_is_better=False))
44 45
45 # Phase measurements in milliseconds. 46 # Phase measurements in milliseconds.
46 domain_lookup_duration = ( 47 domain_lookup_duration = (
47 float(load_timings['domainLookupEnd']) - 48 float(load_timings['domainLookupEnd']) -
48 load_timings['domainLookupStart']) 49 load_timings['domainLookupStart'])
49 results.AddValue(scalar.ScalarValue( 50 results.AddValue(scalar.ScalarValue(
50 results.current_page, 'domain_lookup_duration', 'ms', 51 results.current_page, 'domain_lookup_duration', 'ms',
51 domain_lookup_duration, important=False)) 52 domain_lookup_duration, important=False, higher_is_better=False))
52 53
53 connect_duration = ( 54 connect_duration = (
54 float(load_timings['connectEnd']) - load_timings['connectStart']) 55 float(load_timings['connectEnd']) - load_timings['connectStart'])
55 results.AddValue(scalar.ScalarValue( 56 results.AddValue(scalar.ScalarValue(
56 results.current_page, 'connect_duration', 'ms', connect_duration, 57 results.current_page, 'connect_duration', 'ms', connect_duration,
57 important=False)) 58 important=False, higher_is_better=False))
58 59
59 request_duration = ( 60 request_duration = (
60 float(load_timings['responseStart']) - load_timings['requestStart']) 61 float(load_timings['responseStart']) - load_timings['requestStart'])
61 results.AddValue(scalar.ScalarValue( 62 results.AddValue(scalar.ScalarValue(
62 results.current_page, 'request_duration', 'ms', request_duration, 63 results.current_page, 'request_duration', 'ms', request_duration,
63 important=False)) 64 important=False, higher_is_better=False))
64 65
65 response_duration = ( 66 response_duration = (
66 float(load_timings['responseEnd']) - load_timings['responseStart']) 67 float(load_timings['responseEnd']) - load_timings['responseStart'])
67 results.AddValue(scalar.ScalarValue( 68 results.AddValue(scalar.ScalarValue(
68 results.current_page, 'response_duration', 'ms', response_duration, 69 results.current_page, 'response_duration', 'ms', response_duration,
69 important=False)) 70 important=False, higher_is_better=False))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698