tools/perf/measurements/record_per_area.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/record_per_area.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/perf/benchmarks/dom_perf.py ('K') | « tools/perf/measurements/rasterize_and_record_micro.py ('k') | tools/perf/measurements/task_execution_time.py » ('j') | tools/telemetry/telemetry/value/__init__.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import time	5 import time

6	6

7 from measurements import smoothness	7 from measurements import smoothness

8 from telemetry.page import page_test	8 from telemetry.page import page_test

9 from telemetry.value import scalar	9 from telemetry.value import scalar

10	10

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49	49

50 all_data = tab.EvaluateJavaScript('window.benchmark_results.results')	50 all_data = tab.EvaluateJavaScript('window.benchmark_results.results')

51 for data in all_data:	51 for data in all_data:

52 width = data['width']	52 width = data['width']

53 height = data['height']	53 height = data['height']

54 area = width * height	54 area = width * height

55 time_ms = data['time_ms']	55 time_ms = data['time_ms']

56	56

57 results.AddValue(scalar.ScalarValue(	57 results.AddValue(scalar.ScalarValue(

58 results.current_page, 'area_%07d_%dx%d' % (area, width, height),	58 results.current_page, 'area_%07d_%dx%d' % (area, width, height),

59 'ms', time_ms))	59 'ms', time_ms, higher_is_better=False))

OLD	NEW