tools/perf/measurements/polymer_load.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/polymer_load.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/perf/benchmarks/dom_perf.py ('K') | « tools/perf/measurements/page_cycler.py ('k') | tools/perf/measurements/rasterize_and_record_micro.py » ('j') | tools/telemetry/telemetry/value/__init__.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from telemetry.page import page	5 from telemetry.page import page

6 from telemetry.page import page_test	6 from telemetry.page import page_test

7 from telemetry.value import scalar	7 from telemetry.value import scalar

8	8

9	9

10 class PageForPolymerLoad(page.Page):	10 class PageForPolymerLoad(page.Page):

(...skipping 14 matching lines...) Expand all Loading...
25	25

26 def RunNavigateSteps(self, action_runner):	26 def RunNavigateSteps(self, action_runner):

27 action_runner.NavigateToPage(self)	27 action_runner.NavigateToPage(self)

28 action_runner.WaitForJavaScriptCondition('window.__polymer_ready')	28 action_runner.WaitForJavaScriptCondition('window.__polymer_ready')

29	29

30	30

31 class PolymerLoadMeasurement(page_test.PageTest):	31 class PolymerLoadMeasurement(page_test.PageTest):

32 def ValidateAndMeasurePage(self, _, tab, results):	32 def ValidateAndMeasurePage(self, _, tab, results):

33 result = int(tab.EvaluateJavaScript('__polymer_ready_time'))	33 result = int(tab.EvaluateJavaScript('__polymer_ready_time'))

34 results.AddValue(scalar.ScalarValue(	34 results.AddValue(scalar.ScalarValue(

35 results.current_page, 'Total', 'ms', result))	35 results.current_page, 'Total', 'ms', result, higher_is_better=False))

OLD	NEW