Issue 809363003: Fix iOS useragent detection on offline interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 809363003: Fix iOS useragent detection on offline interstitial (Closed)

Created:
5 years, 11 months ago by edwardjung

Modified:
5 years, 11 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

The useragent is actually 'UIWebVewForStaticContent' rather than the normal agent string exposed to a web page. BUG=424118 Committed: https://crrev.com/9e4517158289852ef0f544d098b38cb83bb4dd68 Cr-Commit-Position: refs/heads/master@{#310784}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/renderer/resources/offline.js	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

edwardjung

Happy new year Erik, Please could you review this bug fix CL. Edward

5 years, 11 months ago (2015-01-06 16:34:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809363003/1

5 years, 11 months ago (2015-01-09 16:20:52 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-09 17:03:21 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9e4517158289852ef0f544d098b38cb83bb4dd68
Cr-Commit-Position: refs/heads/master@{#310784}