Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 809343004: Update the string for offline files. (Closed)

Created:
6 years ago by mtomasz
Modified:
6 years ago
Reviewers:
yawano
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the string for offline files. The checkbox which was referred in the previous version of the string has been moved long long time ago. TEST=Tested manually. BUG=441438 Committed: https://crrev.com/e8cbfd7afd551ea4d8186321d0887f557490eee6 Cr-Commit-Position: refs/heads/master@{#309401}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated the plural string. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@yawano: PTAL. Thanks.
6 years ago (2014-12-22 05:46:01 UTC) #2
yawano
lgtm with nit. Thank you! https://codereview.chromium.org/809343004/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/809343004/diff/1/chrome/app/chromeos_strings.grdp#newcode646 chrome/app/chromeos_strings.grdp:646: <message name="IDS_FILE_BROWSER_OFFLINE_MESSAGE_PLURAL" desc="Message informing ...
6 years ago (2014-12-22 05:57:29 UTC) #3
mtomasz
https://codereview.chromium.org/809343004/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/809343004/diff/1/chrome/app/chromeos_strings.grdp#newcode646 chrome/app/chromeos_strings.grdp:646: <message name="IDS_FILE_BROWSER_OFFLINE_MESSAGE_PLURAL" desc="Message informing the user how to make ...
6 years ago (2014-12-22 06:05:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809343004/20001
6 years ago (2014-12-22 06:06:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-22 06:47:55 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 06:48:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8cbfd7afd551ea4d8186321d0887f557490eee6
Cr-Commit-Position: refs/heads/master@{#309401}

Powered by Google App Engine
This is Rietveld 408576698