components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc - Issue 809313009: Make the SigninErrorController a PKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

Issue 809313009: Make the SigninErrorController a PKS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary header Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/mutable_profile_oauth2_token_service.cc ('k') | components/signin/core/browser/profile_oauth2_token_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

diff --git a/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc b/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

index a7d75ed4fdbd159625bfc4037e9eba396abac8ab..5bbe5d03d0b12427e9a94a4bb5f211c74a52d9bc 100644

--- a/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

+++ b/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

@@ -46,7 +46,7 @@ class MutableProfileOAuth2TokenServiceTest

"",

net::HTTP_OK,

net::URLRequestStatus::SUCCESS);

- oauth2_service_.Initialize(&client_);

+ oauth2_service_.Initialize(&client_, &signin_error_controller_);

// Make sure PO2TS has a chance to load itself before continuing.

base::RunLoop().RunUntilIdle();

oauth2_service_.AddObserver(this);

@@ -119,6 +119,7 @@ class MutableProfileOAuth2TokenServiceTest

TestSigninClient client_;

MutableProfileOAuth2TokenService oauth2_service_;

TestingOAuth2TokenServiceConsumer consumer_;

+ SigninErrorController signin_error_controller_;

int token_available_count_;

int token_revoked_count_;

int tokens_loaded_count_;

@@ -362,7 +363,7 @@ TEST_F(MutableProfileOAuth2TokenServiceTest, FetchTransientError) {

oauth2_service_.StartRequest(kEmail, scope_list, &consumer_));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(GoogleServiceAuthError::AuthErrorNone(),

- oauth2_service_.signin_error_controller()->auth_error());

+ signin_error_controller_.auth_error());

}

TEST_F(MutableProfileOAuth2TokenServiceTest, CanonicalizeAccountId) {