Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: components/signin/core/browser/signin_error_controller.h

Issue 809313009: Make the SigninErrorController a PKS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Copyrighted: 2015 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_ERROR_CONTROLLER_H_ 5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_ERROR_CONTROLLER_H_
6 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_ERROR_CONTROLLER_H_ 6 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_ERROR_CONTROLLER_H_
7 7
8 #include <set> 8 #include <set>
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/observer_list.h" 11 #include "base/observer_list.h"
12 #include "components/keyed_service/core/keyed_service.h"
12 #include "google_apis/gaia/google_service_auth_error.h" 13 #include "google_apis/gaia/google_service_auth_error.h"
13 14
14 // Keep track of auth errors and expose them to observers in the UI. Services 15 // Keep track of auth errors and expose them to observers in the UI. Services
15 // that wish to expose auth errors to the user should register an 16 // that wish to expose auth errors to the user should register an
16 // AuthStatusProvider to report their current authentication state, and should 17 // AuthStatusProvider to report their current authentication state, and should
17 // invoke AuthStatusChanged() when their authentication state may have changed. 18 // invoke AuthStatusChanged() when their authentication state may have changed.
18 class SigninErrorController { 19 class SigninErrorController : public KeyedService {
19 public: 20 public:
20 class AuthStatusProvider { 21 class AuthStatusProvider {
21 public: 22 public:
22 AuthStatusProvider(); 23 AuthStatusProvider();
23 virtual ~AuthStatusProvider(); 24 virtual ~AuthStatusProvider();
24 25
25 // Returns the account id with the status specified by GetAuthStatus(). 26 // Returns the account id with the status specified by GetAuthStatus().
26 virtual std::string GetAccountId() const = 0; 27 virtual std::string GetAccountId() const = 0;
27 28
28 // Returns the username with the status specified by GetAuthStatus(). 29 // Returns the username with the status specified by GetAuthStatus().
29 virtual std::string GetUsername() const = 0; 30 virtual std::string GetUsername() const = 0;
30 31
31 // API invoked by SigninErrorController to get the current auth status of 32 // API invoked by SigninErrorController to get the current auth status of
32 // the various signed in services. 33 // the various signed in services.
33 virtual GoogleServiceAuthError GetAuthStatus() const = 0; 34 virtual GoogleServiceAuthError GetAuthStatus() const = 0;
34 }; 35 };
35 36
36 // The observer class for SigninErrorController lets the controller notify 37 // The observer class for SigninErrorController lets the controller notify
37 // observers when an error arises or changes. 38 // observers when an error arises or changes.
38 class Observer { 39 class Observer {
39 public: 40 public:
40 virtual ~Observer() {} 41 virtual ~Observer() {}
41 virtual void OnErrorChanged() = 0; 42 virtual void OnErrorChanged() = 0;
42 }; 43 };
43 44
44 SigninErrorController(); 45 SigninErrorController();
45 ~SigninErrorController(); 46 ~SigninErrorController() override;
46 47
47 // Adds a provider which the SigninErrorController object will start querying 48 // Adds a provider which the SigninErrorController object will start querying
48 // for auth status. 49 // for auth status.
49 void AddProvider(const AuthStatusProvider* provider); 50 void AddProvider(const AuthStatusProvider* provider);
50 51
51 // Removes a provider previously added by SigninErrorController (generally 52 // Removes a provider previously added by SigninErrorController (generally
52 // only called in preparation for shutdown). 53 // only called in preparation for shutdown).
53 void RemoveProvider(const AuthStatusProvider* provider); 54 void RemoveProvider(const AuthStatusProvider* provider);
54 55
55 // Invoked when the auth status of an AuthStatusProvider has changed. 56 // Invoked when the auth status of an AuthStatusProvider has changed.
(...skipping 19 matching lines...) Expand all
75 // The auth error detected the last time AuthStatusChanged() was invoked (or 76 // The auth error detected the last time AuthStatusChanged() was invoked (or
76 // NONE if AuthStatusChanged() has never been invoked). 77 // NONE if AuthStatusChanged() has never been invoked).
77 GoogleServiceAuthError auth_error_; 78 GoogleServiceAuthError auth_error_;
78 79
79 ObserverList<Observer, false> observer_list_; 80 ObserverList<Observer, false> observer_list_;
80 81
81 DISALLOW_COPY_AND_ASSIGN(SigninErrorController); 82 DISALLOW_COPY_AND_ASSIGN(SigninErrorController);
82 }; 83 };
83 84
84 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_ERROR_CONTROLLER_H_ 85 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_ERROR_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698