Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 809243002: Use ForkWithFlags on the zygote. (Closed)

Created:
6 years ago by rickyz (no longer on Chrome)
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mdempsky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ForkWithFlags on the zygote. The goal of this change is to field test the new sandbox::ForkWithFlags function prior to getting it in base/. BUG=312380 Committed: https://crrev.com/cc28c34fba747ed19dfc4579590822735c004257 Cr-Commit-Position: refs/heads/master@{#308954}

Patch Set 1 #

Patch Set 2 : Explain reasons for using ForkWithFlags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/zygote/zygote_linux.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
rickyz (no longer on Chrome)
Like you suggested, here's a change to exercise ForkWithFlags a bit while I work on ...
6 years ago (2014-12-18 01:11:09 UTC) #2
jln (very slow on Chromium)
lgtm if Matthew doesn't have concerns.
6 years ago (2014-12-18 03:32:27 UTC) #3
mdempsky
lgtm
6 years ago (2014-12-18 04:21:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809243002/20001
6 years ago (2014-12-18 04:46:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-18 05:32:54 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-18 05:35:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc28c34fba747ed19dfc4579590822735c004257
Cr-Commit-Position: refs/heads/master@{#308954}

Powered by Google App Engine
This is Rietveld 408576698