Add super-basic sky widgets.

Add super-basic sky widgets.

Eventually we'll want to replace these with something
fancier like polymer, but this exercise helped us
find several bugs in the engine as well as
removed one more blocker from using Sky to
replace mojo/views usage in mojo/examples.

R=esprehn@chromium.org
BUG=443439
Committed: https://chromium.googlesource.com/external/mojo/+/99614a16d721faafee3831588c37e54824166af1

[esprehn, 2014-12-18 00:54:28]

lgtm, amazing.

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-radio/...
File sky/framework/sky-radio/sky-radio.sky (right):

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-radio/...
sky/framework/sky-radio/sky-radio.sky:41: var scope = radio;
this.ownerScope, I added it :)

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-radio/...
sky/framework/sky-radio/sky-radio.sky:76:
this.setSelected(this.getAttribute('selected'));
this.cachedController = null;

You want to define all your properties inside created() to stay in fast mode.

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-radio/...
sky/framework/sky-radio/sky-radio.sky:89:
this.cachedController.takeSelectionFromGroup(this);
It seems like addRadio should do this?

[abarth-chromium, 2014-12-18 01:23:34]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2014-12-18 01:23:35]

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
File sky/framework/sky-checkbox/sky-checkbox.sky (right):

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
sky/framework/sky-checkbox/sky-checkbox.sky:37: this.toggleChecked();
This this work?  I wouldn't expect |this| to be properly bound at this point...

[esprehn, 2014-12-18 01:24:42]

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
File sky/framework/sky-checkbox/sky-checkbox.sky (right):

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
sky/framework/sky-checkbox/sky-checkbox.sky:37: this.toggleChecked();
On 2014/12/18 at 01:23:35, abarth wrote:
> This this work?  I wouldn't expect |this| to be properly bound at this
point...

In an event listener |this| is the element. It's not obvious though, we should
probably use var self = this in here.

[eseidel, 2014-12-18 01:24:47]

On 2014/12/18 01:23:35, abarth wrote:
>
https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
> File sky/framework/sky-checkbox/sky-checkbox.sky (right):
> 
>
https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
> sky/framework/sky-checkbox/sky-checkbox.sky:37: this.toggleChecked();
> This this work?  I wouldn't expect |this| to be properly bound at this
point...

event handlers are magical, magical beasts.

[Elliot Glaysher, 2014-12-18 20:13:43]

erg@chromium.org changed reviewers:
+ erg@chromium.org

[Elliot Glaysher, 2014-12-18 20:13:43]

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
File sky/framework/sky-checkbox/sky-checkbox.sky (right):

https://codereview.chromium.org/809233002/diff/20001/sky/framework/sky-checkb...
sky/framework/sky-checkbox/sky-checkbox.sky:49: </sky-checkbox>
Does this need to be </sky-element>? All the other files here end with
</sky-element> instead of the element name.

[eseidel, 2014-12-18 21:01:48]

Committed patchset #3 (id:40001) manually as
99614a16d721faafee3831588c37e54824166af1 (presubmit successful).