|
Don't apply column-span:all for display:table-*
The spec doesn't allow this, and we crash if we allow it.
This fix is specific to the old / current multicol implementation. The
new one already does it correctly, FWIW.
The old / current multicol implementation has this concept of block
continuations, which we establish when there's a spanner inside some multicol
child. We do this before considering any render tree fixup for anonymous table
objects. These two render tree fixup mechanisms simply don't play well
together, and since table-* cannot become spanners, according to the spec,
there's no need to make them cope with such situations. Just prevent spanners
in such cases.
BUG= 435815, 443205
R=dsinclair@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187422
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+188 lines, -1 line) |
Patch |
|
A |
LayoutTests/fast/multicol/span/table-caption-crash.html
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-caption-crash-expected.txt
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-cell-crash.html
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-cell-crash-expected.txt
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-column-crash.html
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-column-crash-expected.txt
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-column-group-crash.html
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-column-group-crash-expected.txt
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-row-crash.html
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-row-crash-expected.txt
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-row-group-crash.html
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/span/table-row-group-crash-expected.txt
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderBlock.cpp
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|