Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 809173002: Chromecast: Add a way to notify video plane about resolution changes (Closed)

Created:
6 years ago by servolk
Modified:
6 years ago
Reviewers:
lcwu1, damienv1, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: Add a way to notify video plane about resolution changes Added OnScreenResolutionChanged to be notified about screen resolution changes (needed to fix b/18205424), plus a bit of a refactoring- got rid of platform-specific videoplane registries (duplicated code anyway), introduced a VideoPlaneFactory. BUG=none Committed: https://crrev.com/ab5bcf3cdcfe34635e4fa7ea38d2a92e6ec1eedf Cr-Commit-Position: refs/heads/master@{#308945}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated includes #

Patch Set 3 : Removed plane_id from the VideoPlaneRegistry interface #

Total comments: 10

Patch Set 4 : Addressed CR feedback (virtual, public ctor) #

Patch Set 5 : Simplify videoplane factory, cr feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -22 lines) Patch
M chromecast/media/cma/backend/video_plane.h View 1 2 3 4 3 chunks +11 lines, -2 lines 1 comment Download
M chromecast/media/cma/backend/video_plane.cc View 1 2 3 4 2 chunks +37 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/video_plane_fake.h View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chromecast/media/cma/backend/video_plane_fake.cc View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M chromecast/media/cma/backend/video_plane_fake_factory.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (2 generated)
servolk
PTAL
6 years ago (2014-12-17 22:34:11 UTC) #2
gunsch
Please try to make the first commit message line more indicative of this CL's contents. ...
6 years ago (2014-12-17 22:45:51 UTC) #3
servolk
I think the CL description is accurate, am I missing something? Re. repositioning - it's ...
6 years ago (2014-12-18 00:17:37 UTC) #4
servolk
6 years ago (2014-12-18 01:23:35 UTC) #5
servolk
On 2014/12/18 01:23:35, servolk wrote: ping
6 years ago (2014-12-18 01:47:01 UTC) #6
gunsch
To clarify my comment on the CL commit naming (generally I've gotten pushback from Chromium ...
6 years ago (2014-12-18 02:04:51 UTC) #7
servolk
https://codereview.chromium.org/809173002/diff/40001/chromecast/media/cma/backend/video_plane_fake.h File chromecast/media/cma/backend/video_plane_fake.h (right): https://codereview.chromium.org/809173002/diff/40001/chromecast/media/cma/backend/video_plane_fake.h#newcode17 chromecast/media/cma/backend/video_plane_fake.h:17: virtual gfx::Size GetScreenResolution() override; On 2014/12/18 02:04:51, gunsch wrote: ...
6 years ago (2014-12-18 02:12:25 UTC) #8
gunsch
lgtm
6 years ago (2014-12-18 02:14:21 UTC) #9
lcwu1
https://codereview.chromium.org/809173002/diff/40001/chromecast/media/cma/backend/video_plane.h File chromecast/media/cma/backend/video_plane.h (right): https://codereview.chromium.org/809173002/diff/40001/chromecast/media/cma/backend/video_plane.h#newcode34 chromecast/media/cma/backend/video_plane.h:34: // AVSettings instead. AVSettings is not in the public ...
6 years ago (2014-12-18 02:17:31 UTC) #10
servolk
https://codereview.chromium.org/809173002/diff/40001/chromecast/media/cma/backend/video_plane.h File chromecast/media/cma/backend/video_plane.h (right): https://codereview.chromium.org/809173002/diff/40001/chromecast/media/cma/backend/video_plane.h#newcode34 chromecast/media/cma/backend/video_plane.h:34: // AVSettings instead. On 2014/12/18 02:17:31, lcwu1 wrote: > ...
6 years ago (2014-12-18 02:33:33 UTC) #11
lcwu1
https://codereview.chromium.org/809173002/diff/80001/chromecast/media/cma/backend/video_plane.h File chromecast/media/cma/backend/video_plane.h (right): https://codereview.chromium.org/809173002/diff/80001/chromecast/media/cma/backend/video_plane.h#newcode55 chromecast/media/cma/backend/video_plane.h:55: scoped_ptr<VideoPlane> CreateVideoPlane(); What I mean is to make this ...
6 years ago (2014-12-18 02:51:17 UTC) #12
servolk
On 2014/12/18 02:51:17, lcwu1 wrote: > https://codereview.chromium.org/809173002/diff/80001/chromecast/media/cma/backend/video_plane.h > File chromecast/media/cma/backend/video_plane.h (right): > > https://codereview.chromium.org/809173002/diff/80001/chromecast/media/cma/backend/video_plane.h#newcode55 > ...
6 years ago (2014-12-18 03:01:51 UTC) #13
lcwu1
lgtm
6 years ago (2014-12-18 03:06:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809173002/80001
6 years ago (2014-12-18 03:07:41 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-18 04:01:32 UTC) #17
commit-bot: I haz the power
6 years ago (2014-12-18 04:02:23 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ab5bcf3cdcfe34635e4fa7ea38d2a92e6ec1eedf
Cr-Commit-Position: refs/heads/master@{#308945}

Powered by Google App Engine
This is Rietveld 408576698