Cleanup: Use FOPEN_MAX instead of OPEN_MAX.

Cleanup: Use FOPEN_MAX instead of OPEN_MAX.

http://stackoverflow.com/questions/14042824/where-is-open-max-defined-for-linux-systems

Fixes the following error:
../../util/test/multiprocess_exec_test_child.cc:28:66: error: use of
undeclared identifier 'OPEN_MAX'
  int max_fd = std::max(static_cast<int>(sysconf(_SC_OPEN_MAX)), OPEN_MAX);

R=scottmg@chromium.org
BUG=

[tfarina, 2014-12-18 01:58:35]

Is this OK?

[scottmg, 2014-12-18 03:53:18]

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
File util/test/multiprocess_exec_test_child.cc (right):

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
util/test/multiprocess_exec_test_child.cc:28: int max_fd =
std::max(static_cast<int>(sysconf(_SC_OPEN_MAX)), FOPEN_MAX);
These seems to be quite a bit different on OS X:

[scottmg:/usr/include]$ grep -r OPEN_MAX *
...
stdio.h:#define	FOPEN_MAX	20	/* must be <= OPEN_MAX <sys/syslimits.h> */
sys/syslimits.h:#define	OPEN_MAX		10240	/* max open files per process - todo,
make a config option? */
...

so this seems like it might not test what it's trying to test any more.

[Mark Mentovai, 2014-12-18 13:46:31]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2014-12-18 13:46:31]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2014-12-18 13:46:32]

We’re just getting Windows support in Crashpad started now. We’re not ready for
Linux support yet. I mentioned this yesterday on
https://code.google.com/p/crashpad/issues/detail?id=6.

Not LGTM.

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
File util/test/multiprocess_exec_test_child.cc (right):

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
util/test/multiprocess_exec_test_child.cc:25: // Make sure that there's nothing
open at any FD higher than 3. All FDs other
Please don’t do this. If necessary, set your editor for UTF-8.

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
util/test/multiprocess_exec_test_child.cc:28: int max_fd =
std::max(static_cast<int>(sysconf(_SC_OPEN_MAX)), FOPEN_MAX);
OPEN_MAX and FOPEN_MAX are completely unrelated. This change is wrong.

[Mark Mentovai, 2014-12-18 13:46:32]

We’re just getting Windows support in Crashpad started now. We’re not ready for
Linux support yet. I mentioned this yesterday on
https://code.google.com/p/crashpad/issues/detail?id=6.

Not LGTM.

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
File util/test/multiprocess_exec_test_child.cc (right):

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
util/test/multiprocess_exec_test_child.cc:25: // Make sure that there's nothing
open at any FD higher than 3. All FDs other
Please don’t do this. If necessary, set your editor for UTF-8.

https://codereview.chromium.org/809153003/diff/1/util/test/multiprocess_exec_...
util/test/multiprocess_exec_test_child.cc:28: int max_fd =
std::max(static_cast<int>(sysconf(_SC_OPEN_MAX)), FOPEN_MAX);
OPEN_MAX and FOPEN_MAX are completely unrelated. This change is wrong.

[tfarina, 2014-12-18 14:49:09]

No worry. Will close this.