Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 809133002: ResourceDispatcher: put WeakPtrFactory last (Closed)

Created:
6 years ago by dmichael (off chromium)
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ResourceDispatcher: put WeakPtrFactory last I'm working on turning on a clang checker for this (see the bug). BUG=303818 R=alexclarke1 TBR=jochen@chromium.org Committed: https://crrev.com/7636e55dcf4ce092194ec2ab977e331a939c372b Cr-Commit-Position: refs/heads/master@{#309036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/child/resource_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dmichael (off chromium)
6 years ago (2014-12-17 20:49:55 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-18 12:02:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809133002/1
6 years ago (2014-12-18 17:55:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 18:12:10 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-18 18:14:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7636e55dcf4ce092194ec2ab977e331a939c372b
Cr-Commit-Position: refs/heads/master@{#309036}

Powered by Google App Engine
This is Rietveld 408576698