Fix setting the executable bit in download_from_google_storage.

Fix setting the executable bit in download_from_google_storage.

The new GSUtil (or gs protocol, who knows) strips off the redundent x-goog-meta
string from the metadata key.  This CL compensates for that.

Also since we're on 4.7, we can use the faster gsutil stat instead of gsutil ls -L.

BUG=
TEST=ran download_from_google_storage against compiler_proxy.sha, works
NOTREECHECKS=true
NOTRY=true
R=dnj@chromium.org, pgervais@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293432

[hinoka, 2014-12-17 21:36:16]

hinoka@chromium.org changed reviewers:
+ dnj@chromium.org, jamesr@chromium.org

[dnj, 2014-12-17 21:45:53]

lgtm

[hinoka, 2014-12-17 21:47:01]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2014-12-17 21:47:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809123003/1

[commit-bot: I haz the power, 2014-12-17 21:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 21:50:04]

Presubmit check for 809123003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/download_from_google_storage.py

Pylint (113 files) (125.23s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:41: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module android
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module blink
W: 13, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module ios
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module presubmit_unittest
E:2003, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2003, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2003, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2020, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2020, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2020, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2377, 4: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2396, 4: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2636, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)


Presubmit checks took 164.6s to calculate.

[hinoka, 2014-12-17 21:57:48]

hinoka@chromium.org changed reviewers:
+ pgervais@chromium.org

[hinoka, 2014-12-17 21:57:48]

+pgervais for owners stamp

[pgervais, 2014-12-17 22:32:57]

On 2014/12/17 21:57:48, hinoka wrote:
> +pgervais for owners stamp

rs-lgtm

[jamesr, 2014-12-17 23:36:56]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-12-17 23:37:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809123003/1

[commit-bot: I haz the power, 2014-12-17 23:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 23:40:14]

Presubmit check for 809123003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (113 files) (124.56s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:41: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module android
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module blink
W: 13, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module ios
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module presubmit_unittest
E:2003, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2003, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2003, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2020, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2020, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2020, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2377, 4: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2396, 4: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2636, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)


Presubmit checks took 174.3s to calculate.

[Dirk Pranke, 2014-12-17 23:47:25]

Committed patchset #1 (id:1) manually as 293432.