sync/protocol/proto_enum_conversions.cc - Issue 809073005: replace COMPILE_ASSERT with static_assert in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_enum_conversions.cc

Issue 809073005: replace COMPILE_ASSERT with static_assert in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nit Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/protocol/proto_enum_conversions.cc

diff --git a/sync/protocol/proto_enum_conversions.cc b/sync/protocol/proto_enum_conversions.cc

index eff952fe0f5c4b9998a26daa709b43131cae7dee..e53153347f2ec8a7abb885d71911bec450b3ba5f 100644

--- a/sync/protocol/proto_enum_conversions.cc

+++ b/sync/protocol/proto_enum_conversions.cc

@@ -11,11 +11,11 @@

namespace syncer {

-#define ASSERT_ENUM_BOUNDS(enum_parent, enum_type, enum_min, enum_max) \

- COMPILE_ASSERT(enum_parent::enum_type##_MIN == enum_parent::enum_min, \

- enum_type##_MIN_not_##enum_min); \

- COMPILE_ASSERT(enum_parent::enum_type##_MAX == enum_parent::enum_max, \

- enum_type##_MAX_not_##enum_max);

+#define ASSERT_ENUM_BOUNDS(enum_parent, enum_type, enum_min, enum_max) \

+ static_assert(enum_parent::enum_type##_MIN == enum_parent::enum_min, \

+ #enum_type "_MIN should be " #enum_min); \

+ static_assert(enum_parent::enum_type##_MAX == enum_parent::enum_max, \

+ #enum_type "_MAX should be " #enum_max);

#define ENUM_CASE(enum_parent, enum_value) \

case enum_parent::enum_value: return #enum_value

« no previous file with comments | « sync/internal_api/public/base/ordinal_unittest.cc ('k') | sync/syncable/model_type.cc » ('j') | no next file with comments »