Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809073005: replace COMPILE_ASSERT with static_assert in sync/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in sync/ BUG=442514 Committed: https://crrev.com/21c4d643577ee408e3ba75c32698d86be769ed9c Cr-Commit-Position: refs/heads/master@{#310352}

Patch Set 1 #

Patch Set 2 : fixup #

Patch Set 3 : fixup 2 #

Patch Set 4 : rebase on master #

Total comments: 2

Patch Set 5 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -100 lines) Patch
M sync/api/string_ordinal.h View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M sync/internal_api/public/base/enum_set.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/base/node_ordinal.h View 1 chunk +14 lines, -14 lines 0 comments Download
M sync/internal_api/public/base/ordinal.h View 1 1 chunk +7 lines, -9 lines 0 comments Download
M sync/internal_api/public/base/ordinal_unittest.cc View 1 chunk +44 lines, -44 lines 0 comments Download
M sync/protocol/proto_enum_conversions.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M sync/syncable/model_type.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/nigori_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/syncable/syncable_columns.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/syncable_enum_conversions.cc View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@ncarter: please take a look.
5 years, 11 months ago (2015-01-05 22:07:37 UTC) #2
ncarter (slow)
-me +zea I'm on leave
5 years, 11 months ago (2015-01-07 17:02:03 UTC) #4
maniscalco
lgtm with a nit https://codereview.chromium.org/809073005/diff/60001/sync/syncable/syncable_enum_conversions.cc File sync/syncable/syncable_enum_conversions.cc (right): https://codereview.chromium.org/809073005/diff/60001/sync/syncable/syncable_enum_conversions.cc#newcode20 sync/syncable/syncable_enum_conversions.cc:20: #enum_min " not " #expected_min); ...
5 years, 11 months ago (2015-01-07 18:22:50 UTC) #6
Mostyn Bramley-Moore
https://codereview.chromium.org/809073005/diff/60001/sync/syncable/syncable_enum_conversions.cc File sync/syncable/syncable_enum_conversions.cc (right): https://codereview.chromium.org/809073005/diff/60001/sync/syncable/syncable_enum_conversions.cc#newcode20 sync/syncable/syncable_enum_conversions.cc:20: #enum_min " not " #expected_min); \ On 2015/01/07 18:22:50, ...
5 years, 11 months ago (2015-01-07 19:16:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809073005/80001
5 years, 11 months ago (2015-01-07 19:17:31 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-07 20:30:56 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 20:32:15 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/21c4d643577ee408e3ba75c32698d86be769ed9c
Cr-Commit-Position: refs/heads/master@{#310352}

Powered by Google App Engine
This is Rietveld 408576698